Continuous Voice recording #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a voice recording lock button - Added a new SwiftUI View for expanded voice recording
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Really nice work otherwise, thanks a lot 👍 |
Ivansss
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks a lot @rapterjet2004 for implementing this nice feature! :)
The PR overall looks good, but there is an issue when the user tries to lock the voice recording when the keyboard is being shown.
The new view to delete/stop/send the recording is hidden under the keyboard and it only appears when hidding the keyboard.
ScreenRecording_10-01-2024.18-08-43_1.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Demo
issue-618-1.mov
ToDo