Active account improvements #1802
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
active-account-improvements
branch
from
d1b210b
to
26d89bc
Compare
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
active-account-improvements
branch
from
26d89bc
to
15b7529
Compare
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases we are able to get the associated TalkAccount through a different way than using
activeAccount, so we should try to do that.Currently that does not work in all situations, so that's something to improve on.
At the same time, we only used the method to create a
NCRoomobject without anaccountIdin our tests. So I got rid of that method entirely.