Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm and node engines versions #892

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Update npm and node engines versions #892

merged 1 commit into from
Jan 23, 2024

Conversation

nextcloud-command
Copy link
Contributor

Automated update of the npm and node engines versions

@GretaD
Copy link
Collaborator

GretaD commented Jan 16, 2024

is this blocked by anything? @max-nextcloud

@nextcloud-command nextcloud-command force-pushed the feat/package-node-npm-engines-update branch from bd45493 to c2ec6b4 Compare January 16, 2024 13:22
@max-nextcloud
Copy link
Collaborator

@GretaD It's changing the layout of the package.json file from tabs to two spaces. This will also change the layout of package-lock.json once the next dependency is updated. In general I don't care about the indentation used. However this will make backporting changes that change the dependencies harder - so in text we reverted the whitespace change.

@max-nextcloud max-nextcloud force-pushed the feat/package-node-npm-engines-update branch from c2ec6b4 to a7ab957 Compare January 23, 2024 08:52
max-nextcloud
max-nextcloud approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the whitespace changes. Now this should be ready to go.

@max-nextcloud max-nextcloud merged commit 5361319 into master Jan 23, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/package-node-npm-engines-update branch January 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-command @GretaD @max-nextcloud