Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the user to scroll text to be able to accept the TOS #950

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

GretaD
Copy link
Collaborator

@GretaD GretaD commented Jun 28, 2024

Screencast.from.16.07.2024.13.58.30.webm

@GretaD GretaD self-assigned this Jun 28, 2024
@GretaD GretaD force-pushed the add/force-scroll-tos branch from e74290d to 9eddb5a Compare June 28, 2024 11:30
@ChristophWurst

This comment was marked as outdated.

@GretaD GretaD force-pushed the add/force-scroll-tos branch 2 times, most recently from 0a12fe1 to b1d2856 Compare July 16, 2024 12:00
@GretaD GretaD marked this pull request as ready for review July 16, 2024 12:00
@GretaD GretaD requested a review from max-nextcloud July 16, 2024 12:02
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

@GretaD GretaD force-pushed the add/force-scroll-tos branch from b1d2856 to 8dd3ef4 Compare July 16, 2024 14:45
@GretaD GretaD enabled auto-merge July 16, 2024 14:45
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I had a look at the code but did not test it yet.

https://github.com/nextcloud/terms_of_service/blob/master/src/Registration.vue#L27-L39 also contains a ModalContent. I don't know where the Registration component is shown - but I think it will also need to be adjusted as otherwise the isScrollComplete will default to false and it will be impossible to submit the TOS.

@ChristophWurst ChristophWurst disabled auto-merge July 16, 2024 14:56
@GretaD GretaD requested a review from max-nextcloud July 17, 2024 08:52
@GretaD GretaD force-pushed the add/force-scroll-tos branch from 25dcddf to 7c79011 Compare July 19, 2024 14:26
@GretaD
Copy link
Collaborator Author

GretaD commented Jul 23, 2024

/compile amend

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: greta <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@GretaD GretaD merged commit 34a9bf6 into master Jul 23, 2024
24 checks passed
@AndyScherzinger AndyScherzinger deleted the add/force-scroll-tos branch September 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants