fix(office): getUser from userSession #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$userId` might be injected too early and still be `null`. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/collabora-not-loading
branch
from
d49087a to
37ee294
Compare
max-nextcloud
changed the title
|
So far this is just a suspicion that we are investigating. Still needs to be confirmed that this actually fixes the issue. |
|
Addressing the regression of #260 |
|
I was able to confirm this fixes the |
juliusknorr
approved these changes
Oct 16, 2024
GretaD
approved these changes
Oct 16, 2024
|
I also can confirm this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$userIdmight be injected too early and still benull.Fixes #996.