Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Add strong types to storagewrapper #998

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen
Copy link
Member Author

Since this app also supports 28 on master, this would need checking. Not sure if the wrapper is compliant this way or if we can only add the parameter types but not the return types.

@GretaD GretaD merged commit 4e213aa into master Oct 21, 2024
22 checks passed
@GretaD GretaD deleted the bugfix/noid/adjust-to-storage-changes branch October 21, 2024 11:56
@GretaD
Copy link
Collaborator

GretaD commented Oct 21, 2024

Since this app also supports 28 on master, this would need checking. Not sure if the wrapper is compliant this way or if we can only add the parameter types but not the return types.

tested it with stable28 on server, and this branch on tos app. Doesnt break anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants