Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing configuration key in UpsertProvider (add provider via command) #1063

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bjalbor
Copy link
Contributor

@bjalbor bjalbor commented Feb 18, 2025

closes #1062

Add missing extra options
Add documentation for group provisioning

Björn Bores added 2 commits February 18, 2025 19:39
@julien-nc julien-nc self-requested a review February 19, 2025 14:19
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few adjustments in the README and let's get this in.

Comment on lines +283 to +288
```
sudo -u www-data php /var/www/nextcloud/occ config:app:set user_oidc provider-X-groupProvisioning --value=1
sudo -u www-data php /var/www/nextcloud/occ config:app:set user_oidc provider-X-groupWhitelistRegex --value='/<regex>/'
sudo -u www-data php /var/www/nextcloud/occ config:app:set user_oidc provider-X-restrictLoginToGroups --value=1
```
(where `X` is the numeric provider id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the recommended way to update a provider.
Mentioning the occ user_oidc:provider command should be enough in the README.

```
(where `X` is the numeric provider id)

Or at provider creation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Or at provider creation:
You can configure each provider:
* Toggle group provisioning
* Set the group whitelist regular expression
* Toggle login restriction to people who don't belong to any whitelisted group.
This can be done in the graphical settings, in the "OpenID Connect" admin settings section or with the occ command to create/update providers:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing configuration key in UpsertProvider (Config via Command)
2 participants