-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Close viewer if we navigate back in browser history #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Jan 7, 2025
skjnldsv
approved these changes
Jan 7, 2025
Could you add cypress tests? :) |
juliusknorr
force-pushed
the
fix/browser-back
branch
from
January 7, 2025 17:44
d2c70b4
to
5587108
Compare
Sure, added a simple one |
/compile amend |
Signed-off-by: Julius Knorr <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/browser-back
branch
from
January 7, 2025 17:54
5587108
to
18477e4
Compare
/backport to stable30 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/2661/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 18477e4b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2661/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Closed
8 tasks
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
backport-request
Pending backport by the backport-bot
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser history handling is kind of odd with viewer, this is an attempt to have a small fix for #486 while this should be properly addressed with #2395
We could also do this by using the vue-router in files, but since there is no exposed method to register navigation guards, using native browser APIs seems more straight forward as a backportable fix.
Also this will only fix going backward but if a user decides to go forward in history again, the openfile parameter is not triggering the viewer again. Probably something to check in the files app separately.
I'm not sure if there is a better way to implement this. Would appreciate any feedback