Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close viewer if we navigate back in browser history #2661

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 20, 2024

Browser history handling is kind of odd with viewer, this is an attempt to have a small fix for #486 while this should be properly addressed with #2395

We could also do this by using the vue-router in files, but since there is no exposed method to register navigation guards, using native browser APIs seems more straight forward as a backportable fix.

Also this will only fix going backward but if a user decides to go forward in history again, the openfile parameter is not triggering the viewer again. Probably something to check in the files app separately.

I'm not sure if there is a better way to implement this. Would appreciate any feedback

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Dec 20, 2024
@juliusknorr juliusknorr added this to the Nextcloud 31 milestone Dec 20, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Jan 7, 2025

Could you add cypress tests? :)

@juliusknorr
Copy link
Member Author

Sure, added a simple one

@juliusknorr
Copy link
Member Author

/compile amend

Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 8e984be into master Jan 7, 2025
31 checks passed
@juliusknorr juliusknorr deleted the fix/browser-back branch January 7, 2025 18:15
@juliusknorr
Copy link
Member Author

/backport to stable30

@juliusknorr
Copy link
Member Author

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 7, 2025
Copy link

backportbot bot commented Jan 7, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2661/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 18477e4b

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2661/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants