-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image load error with number folder #2735
fix: image load error with number folder #2735
Conversation
Looks good, can you compile and push the build files? |
done. 😺 |
fe18d22
to
8c08f81
Compare
@fracado can you please remove the merge commit? |
07fba00
to
8c08f81
Compare
Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: Franziska Bath <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
8c08f81
to
c59185d
Compare
Oh, so sorry about that. Updated with a merge commit by mistake. Removed it now. |
/backport to stable31 |
/backport to stable30 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/2735/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972d 134584de c59185dd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2735/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972d 134584de c59185dd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/2735/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972d c59185dd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable31 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2735/stable31."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Didn't see 31 is the only one that worked 🙈 |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2735/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972 c59185d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Well, guess it's not needed 👍 |
Fixes a bug that a file cannot be opened if it is on the same level as a folder with a name that only contains numeric characters.
Only seems to happen with Firefox.
(Note: Very similar issue that existed in nextcloud/photos and has been fixed there with nextcloud/photos#783)