Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image load error with number folder #2735

Merged

Conversation

fracado
Copy link
Contributor

@fracado fracado commented Feb 11, 2025

Fixes a bug that a file cannot be opened if it is on the same level as a folder with a name that only contains numeric characters.
Only seems to happen with Firefox.

(Note: Very similar issue that existed in nextcloud/photos and has been fixed there with nextcloud/photos#783)

@artonge
Copy link
Contributor

artonge commented Feb 11, 2025

Looks good, can you compile and push the build files?

@fracado
Copy link
Contributor Author

fracado commented Feb 11, 2025

Looks good, can you compile and push the build files?

done. 😺

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 11, 2025
@nextcloud nextcloud deleted a comment from backportbot bot Feb 11, 2025
@artonge
Copy link
Contributor

artonge commented Feb 12, 2025

@fracado can you also pull the changes from the "[local]" version of your PR?
This will fix the CI. Sorry for that, CI is a bit fragile in the repo.

@fracado fracado force-pushed the fix/numeric-folder-loading branch from fe18d22 to 8c08f81 Compare February 12, 2025 14:51
@fracado
Copy link
Contributor Author

fracado commented Feb 12, 2025

@fracado can you also pull the changes from the "[local]" version of your PR? This will fix the CI. Sorry for that, CI is a bit fragile in the repo.

okay, done 🙂

@artonge
Copy link
Contributor

artonge commented Feb 13, 2025

@fracado can you please remove the merge commit?

@fracado fracado force-pushed the fix/numeric-folder-loading branch from 07fba00 to 8c08f81 Compare February 13, 2025 09:56
fracado and others added 3 commits February 13, 2025 10:56
Signed-off-by: Franziska Bath <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@fracado fracado force-pushed the fix/numeric-folder-loading branch from 8c08f81 to c59185d Compare February 13, 2025 09:56
@fracado
Copy link
Contributor Author

fracado commented Feb 13, 2025

@fracado can you please remove the merge commit?

Oh, so sorry about that. Updated with a merge commit by mistake. Removed it now.

@skjnldsv skjnldsv added bug Something isn't working 4. to release Ready to be released and/or waiting for tests to finish labels Feb 13, 2025
@skjnldsv
Copy link
Member

/backport to stable31

@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv
Copy link
Member

/backport to stable29

@skjnldsv skjnldsv merged commit 68c3f82 into nextcloud:master Feb 13, 2025
22 of 24 checks passed
Copy link

backportbot bot commented Feb 13, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2735/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972d 134584de c59185dd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Feb 13, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2735/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972d 134584de c59185dd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

/backport 32f8972 c59185d to stable31

Copy link

backportbot bot commented Feb 13, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/2735/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972d c59185dd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/2735/stable31."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

Didn't see 31 is the only one that worked 🙈

@skjnldsv
Copy link
Member

/backport 32f8972 c59185d to stable30

Copy link

backportbot bot commented Feb 13, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2735/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 32f8972 c59185d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2735/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

Well, guess it's not needed 👍

@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants