Select JWK by kid to get around python-jose bug
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python jose has a bug where it'll crash with a JWK type mismatch when validating a JWT against a heterogeneous set of JWKs. I opened a PR against the project to manage that case better in accordance with the JOSE RFC, but that project is is poorly maintained and so it may be worthwhile to work around it for now. Also, it may be worth switching to PyJWT, which supports this use case just as well and is better maintained.
|
mpdavis/python-jose#304 This is the Upstream PR |
|
Thanks for the PR! Sorry getting a lot of github emails and missed this. I think this looks okay. Would indeed prefer to migrate PyJWT if you think it's better maintained. I need to spend some time testing this doesn't break anything for us since we use this in production |
|
@samedii No worries! I maintain a fork we're using ourselves for this, I can help migrate to pyJWT if you're interested. I'd rather help maintain code than start yet another fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python jose has a bug where it'll crash with a JWK type mismatch when validating a JWT against a heterogeneous set of JWKs. I opened a PR against the project to manage that case better in accordance with the JOSE RFC, but that project is is poorly maintained and so it may be worthwhile to work around it for now.
Also, it may be worth switching to PyJWT, which supports this use case just as well and is better maintained.