Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all modules #158

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Update all modules #158

merged 2 commits into from
Dec 12, 2023

Conversation

Aratz
Copy link
Contributor

@Aratz Aratz commented Dec 12, 2023 •
edited
Loading

This PR updates all modules by running nf-core modules update

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2286a3e

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowDemultiplex.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-12-12 09:21:00

@Aratz Aratz marked this pull request as ready for review December 12, 2023 09:20
@Aratz Aratz requested review from nh13, sam-white04, blajoie and a team as code owners December 12, 2023 09:20
@Aratz Aratz requested review from kobelavaerts, maxulysse and edmundmiller and removed request for a team December 12, 2023 09:20
@edmundmiller edmundmiller added this to the 1.4.0 milestone Dec 12, 2023
edmundmiller
edmundmiller approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care of that!

@edmundmiller edmundmiller merged commit dba74c3 into nf-core:dev Dec 12, 2023
6 checks passed
@edmundmiller edmundmiller linked an issue Dec 12, 2023 that may be closed by this pull request
bcl-convert setting of --bcl-num-parallel-tiles causes very poor performance #156
Closed
@Aratz Aratz mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@nh13 nh13 Awaiting requested review from nh13 nh13 is a code owner

@sam-white04 sam-white04 Awaiting requested review from sam-white04 sam-white04 is a code owner

@blajoie blajoie Awaiting requested review from blajoie blajoie is a code owner

@kobelavaerts kobelavaerts Awaiting requested review from kobelavaerts kobelavaerts is a code owner automatically assigned from nf-core/demultiplex

@maxulysse maxulysse Awaiting requested review from maxulysse

Assignees

@Aratz Aratz

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

bcl-convert setting of --bcl-num-parallel-tiles causes very poor performance
2 participants
@Aratz @edmundmiller