Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small inconsistencies and bugs #313

Closed
4 of 5 tasks
erikrikarddaniel opened this issue Jan 27, 2025 · 4 comments
Closed
4 of 5 tasks

Small inconsistencies and bugs #313

erikrikarddaniel opened this issue Jan 27, 2025 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@erikrikarddaniel
Copy link
Member

erikrikarddaniel commented Jan 27, 2025

Description of the bug

When running the dev version (20250127, i.e. after the Diamond thing), I find a couple of annoyances we should fix:

  • One can't run with --help because it complains about --input not being present. I presume the help param is checked too late, i.e. after parsing of params. Probably came with a template update.
  • I get this: WARN: Invalid config manifest attribute contributors``. I guess this is another template update thing. (Probably an old version of Nextflow at Dardel.)
  • There are TODO-strings, at least in the ro-crate...json.
  • "Badges" badly formatted and Zenodo citation missing in README.md
  • We have a couple of unsupported param warnings:
WARN: The following invalid input values have been detected:

* --project: naiss2024-22-470
* --max_memory: 1.7 TB
* --max_cpus: 256
* --max_time: 7d
* --schema_ignore_params: genomes,input_paths,cluster-options,clusterOptions,project,validationSchemaIgnoreParams
* --validationSchemaIgnoreParams: genomes,input_paths,cluster-options,clusterOptions,project,schema_ignore_params
* --validation-schema-ignore-params: genomes,input_paths,cluster-options,clusterOptions,project,schema_ignore_params

Some of these are perhaps because of the pdc_kth config. And --project is perhaps not used by pdc_kth.

Command used and terminal output

Relevant files

No response

System information

No response

@erikrikarddaniel
Copy link
Member Author

@danilodileo One point remains to be checked before we close this one: The badges, i.e. various icons in README.md.

@danilodileo
Copy link
Collaborator

I checked and we have all badges apart from the Citing one. Since we don't have a preprint out we can't solve this issue.

@erikrikarddaniel
Copy link
Member Author

OK, so we have the Zenodo one? If so, just close this issue.

@danilodileo
Copy link
Collaborator

Yes, the Zenodo is there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants