Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor inconcistencies #323

Merged
merged 6 commits into from
Feb 1, 2025
Merged

Minor inconcistencies #323

merged 6 commits into from
Feb 1, 2025

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Jan 31, 2025 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/metatdenovo branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This deals with most if not all of the problems listed in #313 .

I have found the error behind #322 and it's actually captured by test_filter. I don't have time to fix this now, because it requires reworking the R script to deal with missing files. Hopefully, this doesn't mean the tests will fail for this PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 68fc03d

+| ✅ 235 tests passed       |+
!| ❗  26 tests had warnings |!
-| ❌   2 tests failed       |-

❌ Test failures:

  • files_unchanged - assets/nf-core-metatdenovo_logo_light.png does not match the template
  • files_unchanged - docs/images/nf-core-metatdenovo_logo_light.png does not match the template

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-01-31 13:42:13

@erikrikarddaniel
Copy link
Member Author

@nf-core-bot fix linting

@erikrikarddaniel erikrikarddaniel merged commit b6f26c7 into nf-core:dev Feb 1, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilodileo danilodileo Awaiting requested review from danilodileo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikrikarddaniel @danilodileo