Skip to content

Commit

Permalink
ci(wave): Let Dockerfiles fail and request @edmundmiller and @maxulysse
Browse files Browse the repository at this point in the history
  • Loading branch information
edmundmiller committed Nov 14, 2024
1 parent 065fe8d commit cbbce3b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ modules/nf-core/pints/caller/** @edmundmiller
modules/nf-core/preseq/ccurve/** @edmundmiller
modules/nf-core/preseq/lcextrap/** @edmundmiller
subworkflows/nf-core/homer/** @edmundmiller
modules/nf-core/**/Dockerfile @edmundmiller @maxulysse
4 changes: 2 additions & 2 deletions .github/workflows/wave.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ jobs:
return '${{ matrix.files }}'.replace('modules/nf-core/', '').replace('/Dockerfile', '').replace('/', '_');
- name: Build ${{ matrix.profile }} container
# FIXME Hack while iron out the CI
continue-on-error: true
# NOTE If you're changing a Dockerfile and this is running, try to update the Dockerfile to build with wave
continue-on-error: false
env:
PROFILE: ${{ (contains(matrix.profile, 'singularity') && '--singularity') || '' }}
run: |
Expand Down

0 comments on commit cbbce3b

Please sign in to comment.