-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align parabricks subworkflow #6876
base: master
Are you sure you want to change the base?
Conversation
ch_qc_metrics = ch_qc_metrics.mix(PARABRICKS_FQ2BAM.out.qc_metrics) | ||
ch_duplicate_metrics = ch_duplicate_metrics.mix(PARABRICKS_FQ2BAM.out.duplicate_metrics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do you pass this downstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I planned to emit it in the end, its not needed for applybqsr though.
Co-authored-by: Maxime U Garcia <[email protected]>
@sateeshperi Do you have any idea why the fq2bam process seems to not produce the expected output bam files? |
ext.args = '--low-memory' | ||
} | ||
// Ref: https://forums.developer.nvidia.com/t/problem-with-gpu/256825/6 | ||
// Parabricks’s fq2bam requires 24GB of memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe do a
// Parabricks’s fq2bam requires 24GB of memory. | |
// Parabricks’s fq2bam requires 24GB of memory. | |
// resourceLimits = [cpus: 6GB, memory: 24.GB] | |
memory = '24.GB' |
https://docs.nvidia.com/clara/parabricks/latest/documentation/tooldocs/man_fq2bam.html#man-fq2bam
Also it would be awesome to do some thing like --memory-limit ${task.memory} / 2
by default or make sure there's 16 cpus per GPU requested.
Just trying to push the resourceLimits syntax to the limits here 😆
PR checklist
Closes #6894
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda