-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a TrueType font for plotting sequence names with last/dotplot
.
#7404
Conversation
The `last-dotplot` command normally picks scalable fonts by default but did not manage to do so on the conda install in the images. Therefore I hardcode the path (which is likely to change when the images are updated). Not using a scalable font prevents users from changing the font size using the command-line argument `-s` of `last-dotplot`. In addition, I found that the CI tests did not check the outputted images, and corrected that too in this commit.
Thanks @mashehu but the failing tests on conda revealed a real problem that I do not know how to solve now… I asked the following question on Slack:
|
Thanks: Leon Hafner
Hi @mashehu I finally found the path of the file on conda installs. This leaves a messy commit history so I wanted to ask you if you would prefer me to open a new PR with squashed commits, and if you are fine with my final solution. |
Good job! The commits will be squashed anyway when the PR is merged, so no worries about the git history. |
The
last-dotplot
command normally picks scalable fonts by default but did not manage to do so on the conda install in the images. Therefore I hardcode the path (which is likely to change when the images are updated).Not using a scalable font prevents users from changing the font size using the command-line argument
-s
oflast-dotplot
.In addition, I found that the CI tests did not check the outputted images, and corrected that too in this commit.
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda