Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the version before the patch release v.1.2.2 #562

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Bump the version before the patch release v.1.2.2 #562

merged 4 commits into from
Dec 20, 2024

Conversation

LilyAnderssonLee
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8b4ec22

+| ✅ 277 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • nextflow_config - Config manifest.version should end in dev: 1.2.2
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.0
  • Run at 2024-12-20 09:27:08

LilyAnderssonLee
LilyAnderssonLee commented Dec 19, 2024
View reviewed changes
assets/multiqc_config.yml Outdated
@@ -98,22 +99,26 @@ top_modules:
- "*raw*"
path_filters_exclude:
- "*processed*"
extra: "If used in this run, Falco is a drop-in replacement for FastQC producing the same output, written by Guilherme de Sena Brandine and Andrew D. Smith."
extra: "If used in this run, Falco is a drop-in replacement for FastQC producing
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfy133 Not sure why there are so many spaces and new lines. It might be due to some weird behavior in my VS Code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something has indeed gone weird, this doesn't look right...

jfy133
jfy133 reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's something to do with the new bump-versions thing?

Maube something to ask on #tools

assets/multiqc_config.yml Outdated
@@ -98,22 +99,26 @@ top_modules:
- "*raw*"
path_filters_exclude:
- "*processed*"
extra: "If used in this run, Falco is a drop-in replacement for FastQC producing the same output, written by Guilherme de Sena Brandine and Andrew D. Smith."
extra: "If used in this run, Falco is a drop-in replacement for FastQC producing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something has indeed gone weird, this doesn't look right...

jfy133
jfy133 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog header too and GTG

@LilyAnderssonLee LilyAnderssonLee merged commit 6a9da1a into dev Dec 20, 2024
25 checks passed
@LilyAnderssonLee LilyAnderssonLee deleted the pre-release_vbump branch December 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilyAnderssonLee @jfy133