Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master for v3.0.0 #3197

Merged
merged 940 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
940 commits
Select commit Hold shift + click to select a range
f2b282c
add option to exclude fastqc from pipeline template
mirpedrol Aug 21, 2024
e4f685d
[automated] Update CHANGELOG.md
nf-core-bot Aug 21, 2024
0e4a7d1
don't fail when no nf-core modules installed
mirpedrol Aug 26, 2024
92618ad
fix versions yaml file name
mirpedrol Aug 26, 2024
d437582
udpate bpipe and fix pytests
mirpedrol Aug 26, 2024
9551cdc
Apply suggestions from code review
mirpedrol Aug 26, 2024
9d29e93
update textual snapshots
mirpedrol Aug 26, 2024
2eb5458
Merge pull request #3129 from mirpedrol/template-customisation-fastqc
mirpedrol Aug 26, 2024
52da9e3
[automated] Update CHANGELOG.md
nf-core-bot Aug 21, 2024
a8cb940
Apply suggestions from code review
mirpedrol Aug 26, 2024
bcbed05
update textual snapshots
mirpedrol Aug 26, 2024
769c6fc
Merge pull request #3130 from mirpedrol/template-customisation-docume…
mirpedrol Aug 26, 2024
d3d6345
add option to exclude test configs from pipeline template
mirpedrol Aug 22, 2024
b301c5c
[automated] Update CHANGELOG.md
nf-core-bot Aug 22, 2024
4552219
update textual snapshots
mirpedrol Aug 26, 2024
25030e3
filter generated matrix with yq
mirpedrol Aug 26, 2024
40a8bcb
Merge pull request #3133 from mirpedrol/template-customisation-testing
mirpedrol Aug 26, 2024
498435b
add option to exclude tower.yml from pipeline template
mirpedrol Aug 22, 2024
0f96bb3
[automated] Update CHANGELOG.md
nf-core-bot Aug 22, 2024
b85ea4d
update nf-schema subwf
nvnieuwk Aug 26, 2024
c538cfd
Merge branch 'dev' into feat/linting-nf-schema
nvnieuwk Aug 26, 2024
0dd8d6f
update textual snapshots
mirpedrol Aug 26, 2024
0fb97db
fix some issues
nvnieuwk Aug 26, 2024
7dee447
fix linting utils_nfschema_plugin
nvnieuwk Aug 26, 2024
6d01b0f
update utils subwfs
nvnieuwk Aug 26, 2024
ee85104
Merge pull request #3134 from mirpedrol/template-customisation-tower
mirpedrol Aug 26, 2024
a7dcdd7
fix some linting issues
nvnieuwk Aug 27, 2024
a77f5a1
Merge branch 'dev' into feat/linting-nf-schema
nvnieuwk Aug 27, 2024
fcdf65b
ruff
nvnieuwk Aug 27, 2024
56150dc
add linting doc for plugin_includes
nvnieuwk Aug 27, 2024
5a29c4e
readd file exists check
nvnieuwk Aug 27, 2024
18738ef
fix launch command
nvnieuwk Aug 27, 2024
ebf6a27
fix schema tests
nvnieuwk Aug 27, 2024
04fabe5
ruff
nvnieuwk Aug 27, 2024
0649a75
readd file exists check
nvnieuwk Aug 27, 2024
9fd9869
fix lint test
nvnieuwk Aug 27, 2024
6cccc1e
update textual snapshots
mirpedrol Aug 27, 2024
2ccbdd9
skip linting before and after Text params for custom pipelines
mirpedrol Aug 27, 2024
ed01eba
typo
mirpedrol Aug 27, 2024
1b597f1
Update nf_core/pipeline-template/nextflow.config
nvnieuwk Aug 27, 2024
93cc41b
Update nf_core/pipeline-template/subworkflows/local/utils_nfcore_pipe…
nvnieuwk Aug 27, 2024
6e358f3
Update nf_core/pipeline-template/subworkflows/local/utils_nfcore_pipe…
nvnieuwk Aug 27, 2024
dbe9318
Update nf_core/pipeline-template/subworkflows/local/utils_nfcore_pipe…
nvnieuwk Aug 27, 2024
4025b54
Update nf_core/pipelines/create/templatefeatures.yml
nvnieuwk Aug 27, 2024
679de82
Update tests/pipelines/lint/test_plugin_includes.py
nvnieuwk Aug 27, 2024
3ac1bd8
review suggestions
nvnieuwk Aug 27, 2024
d4266c0
use latest version of utils_nextflow_pipeline
nvnieuwk Aug 27, 2024
bc20099
make help params snake_case
nvnieuwk Aug 27, 2024
829d594
Update nf_core/pipelines/create/templatefeatures.yml
nvnieuwk Aug 27, 2024
1ff7cbc
Update nf_core/pipelines/lint/plugin_includes.py
nvnieuwk Aug 27, 2024
aed9460
apply review suggestions
nvnieuwk Aug 27, 2024
7612e66
Merge branch 'feat/linting-nf-schema' of github.com:nvnieuwk/tools in…
nvnieuwk Aug 27, 2024
4407901
update utils_nextflow_pipeline commit messages
nvnieuwk Aug 27, 2024
330e43c
update ignoring of help params
nvnieuwk Aug 27, 2024
3600db7
update file exists docstring
nvnieuwk Aug 27, 2024
e816faf
update snapshot
nvnieuwk Aug 27, 2024
7d23535
Merge pull request #3116 from nvnieuwk/feat/linting-nf-schema
nvnieuwk Aug 27, 2024
deb7186
fix sync pipeline from current directory
mirpedrol Aug 27, 2024
a1e2c15
update changelog
mirpedrol Aug 27, 2024
b4acddc
Merge pull request #3143 from mirpedrol/fix-sync-dir
mirpedrol Aug 27, 2024
21b81ef
add option to exclude nf-core components from pipeline template
mirpedrol Aug 21, 2024
a552e13
add option to exclude nf-core components from pipeline template
mirpedrol Aug 21, 2024
36b559e
allow linting a pipeline without nf-core components
mirpedrol Aug 27, 2024
cb3e9e6
don't detect nfcore_components as a linting test
mirpedrol Aug 27, 2024
3403f2e
apply review comments from @mashehu
mirpedrol Aug 27, 2024
bed7b37
don't remove base.config when removing nf-core components
mirpedrol Aug 27, 2024
6a5d830
Revert "don't remove base.config when removing nf-core components"
mirpedrol Aug 27, 2024
1b8cce2
update textual snapshots
mirpedrol Aug 27, 2024
8351e0c
add process cpus, memory and time to nextflow.config if we remove bas…
mirpedrol Aug 27, 2024
4e385ab
Merge pull request #3128 from mirpedrol/template-customisation-nfcore…
mirpedrol Aug 28, 2024
d295def
add tests to ensure all files are part of a template customisation group
mirpedrol Aug 5, 2024
f700e61
fix linting
mirpedrol Aug 5, 2024
b8812e8
update changelog
mirpedrol Aug 5, 2024
e6507cc
rename templatefeatures.yml to template_features.yml
mirpedrol Aug 28, 2024
fcfdbaf
update test to use template_features.yml and add missing files to a f…
mirpedrol Aug 28, 2024
ea52f9b
fix pipeline linting when skipping nf_schema
mirpedrol Aug 28, 2024
fc7c1e8
switch to os.walk to support <3.10 versions of Python
mirpedrol Aug 28, 2024
aa2a417
handle cases where the directory path contains the name of the component
mirpedrol Aug 29, 2024
847fe0b
udpate changelog
mirpedrol Aug 29, 2024
3d475d5
Merge pull request #3147 from mirpedrol/module-pipeline-same-name
mirpedrol Aug 29, 2024
283284c
some more minimal template fixes
mirpedrol Aug 29, 2024
43b3574
update textual snapshots
mirpedrol Aug 29, 2024
a0682c3
don't remove .gitignore when unselecting github
mirpedrol Aug 29, 2024
825d7b6
update textual snapshots
mirpedrol Aug 29, 2024
5b9eff5
add .gitignore to base required files
mirpedrol Aug 29, 2024
21e03ec
run nf-core lint --release on PRs to master
mirpedrol Aug 30, 2024
424743e
udpate changelog
mirpedrol Aug 30, 2024
a5718f7
test pipeline with conda and singularity on PRs to master
mirpedrol Aug 30, 2024
248b669
add workflow_dispatch to pipeline ci test
mirpedrol Aug 30, 2024
88f9735
update changelog
mirpedrol Aug 30, 2024
1be881e
Update pre-commit hook pre-commit/mirrors-mypy to v1.11.2
renovate[bot] Sep 1, 2024
17eb143
Update dependency textual-dev to v1.6.1
renovate[bot] Sep 1, 2024
d67733c
Update dependency pytest-textual-snapshot to v1
renovate[bot] Sep 1, 2024
94d28d1
Update pre-commit hook editorconfig-checker/editorconfig-checker.pyth…
renovate[bot] Sep 1, 2024
8fb9982
Merge branch 'dev' into test-template-customisation
ewels Sep 1, 2024
fef0829
markdown header
ewels Sep 1, 2024
25224a0
Merge pull request #3099 from mirpedrol/test-template-customisation
ewels Sep 1, 2024
6482287
fix issue where tool and subtool have the same name
nvnieuwk Sep 3, 2024
05c238e
pre commit
nvnieuwk Sep 3, 2024
2e690d9
Merge branch 'dev' into deprecate-cehck_max_function
jfy133 Sep 4, 2024
736d5e8
Removes all remaining references to max_* params
jfy133 Sep 4, 2024
5563360
[automated] Fix code linting
nf-core-bot Sep 4, 2024
6633769
Fix linting fail
jfy133 Sep 4, 2024
d819232
Fix schema error
jfy133 Sep 4, 2024
f3138fc
Merge branch 'deprecate-cehck_max_function' of github.com:jfy133/nf-c…
jfy133 Sep 4, 2024
b6e19d8
add a tabix tabix test
nvnieuwk Sep 5, 2024
308baef
Merge pull request #3156 from nvnieuwk/fix/tool-subtool-same-name
nvnieuwk Sep 5, 2024
dad359c
Add --update-all flag to remove defaults channels dependents
mahesh-panchal Sep 5, 2024
1c6b577
Update CHANGELOG.md
mahesh-panchal Sep 5, 2024
d6bd738
Merge pull request #3159 from mahesh-panchal/patch_conda_gitpod
mahesh-panchal Sep 5, 2024
4f930c1
Don't test conda `environment.yml` `name` attribute (which should no …
ewels Sep 6, 2024
0593114
Remove name from conda enviroment.yml in module template
ewels Sep 6, 2024
ac88c16
Remove tests involving environment.yml with 'name'
ewels Sep 6, 2024
16d66cb
Merge pull request #3161 from ewels/module-lint-no-name
ewels Sep 6, 2024
6b3e848
Don't look for dev, look for not master
ewels Sep 6, 2024
3e020cf
Move if statements to top of YAML blocks
ewels Sep 6, 2024
4f31818
Merge branch 'dev' into lint-release
ewels Sep 6, 2024
8e47a33
Merge pull request #3148 from mirpedrol/lint-release
ewels Sep 6, 2024
4aa2f07
update modules
mirpedrol Sep 13, 2024
367f647
update syntax in utils_nfcore_pipeline_pipeline
mirpedrol Sep 13, 2024
47d4440
update changelog
mirpedrol Sep 13, 2024
5987085
add optional inputs to multiqc module
mirpedrol Sep 13, 2024
21175dc
add fake version to fix pytest
mirpedrol Sep 13, 2024
9765f18
Remove if/else block to include igenomes.config and add igenomes_igno…
mirpedrol Sep 16, 2024
c63ef83
exclude CITATIONS.md file when excluding citations from pipeline temp…
mirpedrol Sep 16, 2024
5599039
add tests back
mirpedrol Sep 16, 2024
e87478d
Merge branch 'dev' of https://github.com/nf-core/tools into deprecate…
mirpedrol Sep 16, 2024
c568ce9
more pytest fixing
mirpedrol Sep 16, 2024
809074b
Merge branch 'dev' of https://github.com/nf-core/tools into modules-y…
mirpedrol Sep 17, 2024
c2488b5
Strip hyphens from hashtags for mastodon compatibiluty
jfy133 Sep 18, 2024
53448ce
fixes for linting modules without an input
mirpedrol Sep 18, 2024
bebc6bc
Update CHANGELOG.md
jfy133 Sep 18, 2024
494a03f
fix broken lint test by adding module dependency version
mirpedrol Sep 19, 2024
e113f97
Merge pull request #3176 from nf-core/fix-masto-hashtags
mirpedrol Sep 19, 2024
17dc0bc
change order of profiles used for CI
mirpedrol Sep 19, 2024
482c40b
Merge branch 'dev' into deprecate-cehck_max_function
mirpedrol Sep 19, 2024
c494c26
update nextflow version on CI
mirpedrol Sep 19, 2024
2c0d2f6
configs are included after profiles
mirpedrol Sep 19, 2024
d2959ed
reduce memory in test profile
mirpedrol Sep 19, 2024
5354770
Apply suggestions from code review
mirpedrol Sep 19, 2024
eefa57a
Merge branch 'dev' into modules-yml-ontology
mirpedrol Sep 19, 2024
b2e6397
Merge pull request #3037 from jfy133/deprecate-cehck_max_function
mirpedrol Sep 20, 2024
c8c4fbe
Merge branch 'dev' into modules-yml-ontology
mirpedrol Sep 20, 2024
282e8fe
Merge pull request #3032 from mirpedrol/modules-yml-ontology
mirpedrol Sep 20, 2024
f31e6b5
Merge branch 'dev' of https://github.com/nf-core/tools into subworkfl…
mirpedrol Sep 20, 2024
1e18f14
bump nf-schema to v2.1.1 in the template
nvnieuwk Sep 20, 2024
e2c4740
remove help params from ignore params
nvnieuwk Sep 20, 2024
9e05574
Merge pull request #3177 from nf-core/nvnieuwk-patch-1
nvnieuwk Sep 20, 2024
eb58583
Merge branch 'dev' into subworkflows-meta-yml-restructure
mirpedrol Sep 20, 2024
ebfbd98
fix pytests by mocking biotools, adding a meta to the test module and…
mirpedrol Sep 20, 2024
0447d1a
update template modules
mirpedrol Sep 23, 2024
200ae85
add testing the module name back
mirpedrol Sep 23, 2024
0e3a35b
fix info command for the new yaml structure
mirpedrol Sep 23, 2024
23c2612
fix modules pytest
mirpedrol Sep 23, 2024
b41e64c
fix subworkflows pytest
mirpedrol Sep 23, 2024
b249b13
update pipeline for multiqc update
mirpedrol Sep 23, 2024
a2ffa44
fix more pytests
mirpedrol Sep 23, 2024
34ead3e
remove try-catch blocks from nextflow.config
mirpedrol Sep 13, 2024
930933b
change the name of tmp pipeline to be consistent with all tests
mirpedrol Sep 16, 2024
e6fdba8
update nextflow_config linting to include the new includeconfig line
mirpedrol Sep 16, 2024
3dff654
Merge branch 'dev' into genomes-map
mirpedrol Sep 25, 2024
fc6d875
add linting for igenomes_ignored.config
mirpedrol Sep 25, 2024
cd4eb07
Merge branch 'dev' into import-statements
mirpedrol Sep 25, 2024
854ddf9
remove missing check_max from nextflow.config
mirpedrol Sep 25, 2024
9b79f21
Merge branch 'dev' into renovate/pytest-textual-snapshot-1.x
mirpedrol Sep 26, 2024
2c64df3
regenerate textual snapshots which are now stored in separate files
mirpedrol Sep 27, 2024
8d5f898
remove code duplication and format components info command
mirpedrol Sep 27, 2024
b3042f3
Merge pull request #3077 from mirpedrol/subworkflows-meta-yml-restruc…
mirpedrol Sep 27, 2024
d7a98a0
Merge branch 'dev' into check-max
mirpedrol Sep 27, 2024
b1304aa
Merge pull request #3180 from mirpedrol/check-max
mirpedrol Sep 27, 2024
c122bc6
Merge branch 'dev' into genomes-map
mirpedrol Sep 27, 2024
efc11ba
add conf/igenomes_ignored.config to linting
mirpedrol Sep 27, 2024
9f4a4bb
Merge pull request #3168 from mirpedrol/genomes-map
mirpedrol Sep 27, 2024
2709393
remove try-catch blocks from nextflow.config
mirpedrol Sep 13, 2024
b1df038
change the name of tmp pipeline to be consistent with all tests
mirpedrol Sep 16, 2024
7e738ea
update nextflow_config linting to include the new includeconfig line
mirpedrol Sep 16, 2024
8a3f782
Merge branch 'dev' into import-statements
maxulysse Sep 27, 2024
d15925a
Merge branch 'dev' into renovate/pytest-textual-snapshot-1.x
mirpedrol Sep 30, 2024
f54d92f
Merge pull request #3154 from nf-core/renovate/pytest-textual-snapsho…
mirpedrol Sep 30, 2024
e46779b
add test on pipeline release to check that custom configs are included
mirpedrol Sep 30, 2024
68023d0
Merge branch 'try-catch' of https://github.com/mirpedrol/tools into t…
mirpedrol Sep 30, 2024
530b515
Merge branch 'dev' of https://github.com/nf-core/tools into try-catch
mirpedrol Sep 30, 2024
70b231e
fix tests by uncommenting includeConfig statements
mirpedrol Sep 30, 2024
3a0a8ca
fix sed commands
mirpedrol Sep 30, 2024
c779bf4
formatted string
mirpedrol Sep 30, 2024
d625d92
test output directory typo
mirpedrol Sep 30, 2024
19d21bb
fix more output directory errors
mirpedrol Sep 30, 2024
5f367d1
generate API docs
mirpedrol Sep 30, 2024
ae50840
Refactor CLI commands for Download.
MatthiasZepper Sep 23, 2024
95435c9
Adapt tests for the new Pipelines Download CLI.
MatthiasZepper Sep 23, 2024
5dea0d0
Fix GitHub Action in pipeline-template and update Changelog.
MatthiasZepper Sep 23, 2024
b8c9717
Merge pull request #3167 from mirpedrol/try-catch
mirpedrol Sep 30, 2024
c30967e
Merge pull request #3151 from nf-core/renovate/pre-commit-mirrors-myp…
mashehu Sep 30, 2024
a05cc8f
Merge pull request #3155 from nf-core/renovate/editorconfig-checker-e…
mashehu Sep 30, 2024
cd138ec
Merge branch 'dev' into pipeline-test-conda-syngularity
mirpedrol Oct 1, 2024
5efff0b
Merge pull request #3149 from mirpedrol/pipeline-test-conda-syngularity
mirpedrol Oct 1, 2024
1e5f39a
Merge branch 'dev' into citationsmd
mirpedrol Oct 1, 2024
91e9de5
skip citations.md from linting
mirpedrol Oct 1, 2024
151dc92
Merge pull request #3169 from mirpedrol/citationsmd
mirpedrol Oct 1, 2024
f6f0b3c
Merge pull request #3166 from mirpedrol/import-statements
mirpedrol Oct 1, 2024
2a35da1
Merge pull request #3178 from MatthiasZepper/download_cli_refactor
MatthiasZepper Oct 1, 2024
b75ba51
fix old nf-core sync command and use the info from .nf-core.yml to sy…
mirpedrol Oct 1, 2024
a3468d3
udpate nf-core version and outdir before writing to the template .nf-…
mirpedrol Oct 2, 2024
d0a24be
udpate yaml config only in pipeline repos
mirpedrol Oct 2, 2024
c95de5d
fix pytests
mirpedrol Oct 2, 2024
0b2e227
take into account empty directories
mirpedrol Oct 2, 2024
b8b0c7b
Update nf_core/utils.py
mirpedrol Oct 2, 2024
1ac4e06
Update nf_core/utils.py
mirpedrol Oct 2, 2024
97bc4ea
update strip commands
mirpedrol Oct 2, 2024
86f436a
apply comments from code review by @mashehu
mirpedrol Oct 2, 2024
26299f0
more code suggestions, thanks @mashehu
mirpedrol Oct 2, 2024
bd1e498
Merge pull request #3185 from mirpedrol/sync-fixes
mirpedrol Oct 2, 2024
d52969b
Update gitpod/workspace-base Docker digest to 2cc134f
renovate[bot] Oct 2, 2024
93c2def
fix running prettier on rendered template
mashehu Oct 3, 2024
38db8cb
Merge pull request #3188 from mashehu/fix-run-prettier
mashehu Oct 3, 2024
320037f
sync: copy modules.json to TEMPLATE branch
mashehu Oct 4, 2024
8192ca6
remove unused imports
mashehu Oct 4, 2024
89a41eb
handle non-existent modules.json file more gracefully
mashehu Oct 4, 2024
375fad3
fix template new lines
mirpedrol Oct 4, 2024
80cca2f
add pydantic autodoc
mashehu Oct 4, 2024
f063bf5
render also utils.py docs
mashehu Oct 4, 2024
4ea3650
include review comments and links to docs
mashehu Oct 4, 2024
46b998b
install modules in TEMPLATE branch
mashehu Oct 4, 2024
fa1a01d
remove modules.json copy step in sync
mashehu Oct 4, 2024
bb2b10d
Merge pull request #3189 from mashehu/sync-modules
mashehu Oct 4, 2024
d6cd273
Improve the Github Action to test offline support better.
MatthiasZepper Sep 26, 2024
ca5eaa5
Add raw statements for template and update Singularity version in run…
MatthiasZepper Sep 26, 2024
5c39ab8
Fix container image count calculation.
MatthiasZepper Sep 26, 2024
f54e9eb
Merge pull request #3190 from mirpedrol/template-newlines
mirpedrol Oct 4, 2024
8feb89b
chore(deps): update pre-commit hook astral-sh/ruff-pre-commit to v0.6.9
renovate[bot] Oct 4, 2024
89961d6
Tidy Jinja template markup.
MatthiasZepper Oct 4, 2024
664fbfa
The raw statements must not wrap other Jinja markup.
MatthiasZepper Oct 4, 2024
b36c433
Merge pull request #3182 from MatthiasZepper/seqera_community_containers
MatthiasZepper Oct 4, 2024
78d7d8a
Merge pull request #3150 from nf-core/renovate/astral-sh-ruff-pre-com…
mashehu Oct 4, 2024
fc9c001
chore(deps): update python:3.12-slim docker digest to af4e85f
renovate[bot] Oct 4, 2024
aa15820
add pipeline name as an optional sync input
mashehu Oct 7, 2024
6a2b0af
Merge pull request #3194 from mashehu/add-input-to-sync-gha
mashehu Oct 7, 2024
962f4b3
fix for multiqc_config template for released pipelines
mashehu Oct 7, 2024
baeb1df
bump version to 3.0.0
mirpedrol Oct 7, 2024
0865cd1
update nf-core command in sync.yml
mashehu Oct 7, 2024
f20f797
fix some more template newlines
mirpedrol Oct 7, 2024
938fd34
Merge pull request #3195 from mashehu/fix-whitespaces
mirpedrol Oct 7, 2024
baa88db
Merge branch 'dev' into renovate/textual-dev-1.x
mirpedrol Oct 7, 2024
3d56fd1
Merge pull request #3153 from nf-core/renovate/textual-dev-1.x
mirpedrol Oct 7, 2024
503843d
Merge pull request #3196 from mirpedrol/bump-to-3-0-0
mirpedrol Oct 7, 2024
a506b1d
review suggestions by @mashehu
mirpedrol Oct 8, 2024
0cfca70
update release date
mirpedrol Oct 8, 2024
86458e9
Merge branch 'dev' into release-checklist
mashehu Oct 8, 2024
83c0be4
Merge pull request #2989 from mirpedrol/release-checklist
mashehu Oct 8, 2024
9489c1c
Merge pull request #3199 from mirpedrol/release-review
mashehu Oct 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 8 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,11 @@ indent_style = unset

[**/Makefile]
indent_style = unset

[tests/pipelines/__snapshots__/*]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset
indent_size = unset
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ body:
description: Steps to reproduce the behaviour. Please paste the command and output from your terminal.
render: console
placeholder: |
$ nf-core lint ...
$ nf-core pipelines lint ...

Some output where something broke

Expand Down
10 changes: 5 additions & 5 deletions .github/RELEASE_CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
7. Create a PR from `dev` to `master`
8. Make sure all CI tests are passing again (additional tests are run on PRs to `master`)
9. Request review (2 approvals required)
10. Run `rich-codex` to regenerate docs screengrabs (actions `workflow_dispatch` button)
11. Merge the PR into `master`
12. Wait for CI tests on the commit to passed
13. (Optional but a good idea) Run a manual sync on `nf-core/testpipeline` and check that CI is passing on the resulting PR.
14. Create a new release copying the `CHANGELOG` for that release into the description section.
10. Merge the PR into `master`
11. Wait for CI tests on the commit to passed
12. (Optional but a good idea) Run a manual sync on `nf-core/testpipeline` and check that CI is passing on the resulting PR.
13. Create a new release copying the `CHANGELOG` for that release into the description section.

## After release

1. Check the automated template synchronisation has been triggered properly. This should automatically open PRs directly to individual pipeline repos with the appropriate changes to update the pipeline template.
2. Check that the automatic `PyPi` deployment has worked: [pypi.org/project/nf-core](https://pypi.org/project/nf-core/)
3. Check `BioConda` has an automated PR to bump the version, and merge. eg. [bioconda/bioconda-recipes #20065](https://github.com/bioconda/bioconda-recipes/pull/20065)
4. Create a tools PR to `dev` to bump back to the next development version in `CHANGELOG.md` and `setup.py` and change the gitpod container to `nfcore/gitpod:dev`.
5. Run `rich-codex` on the [tools/website repo](https://github.com/nf-core/website/actions/workflows/rich-codex.yml) to regenerate docs screengrabs (actions `workflow_dispatch` button)
26 changes: 16 additions & 10 deletions .github/actions/create-lint-wf/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ runs:
run: |
mkdir -p create-lint-wf && cd create-lint-wf
export NXF_WORK=$(pwd)
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --plain
nf-core --log-file log.txt pipelines create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface"

# Try syncing it before we change anything
- name: nf-core sync
- name: nf-core pipelines sync
shell: bash
run: nf-core --log-file log.txt sync --dir nf-core-testpipeline/
run: nf-core --log-file log.txt pipelines sync --dir nf-core-testpipeline/
working-directory: create-lint-wf

# Run code style linting
Expand All @@ -53,26 +53,32 @@ runs:
run: find nf-core-testpipeline -type f -exec sed -i '/TODO nf-core:/d' {} \;
working-directory: create-lint-wf

# Uncomment includeConfig statement
- name: uncomment include config
shell: bash
run: find nf-core-testpipeline -type f -exec sed -i 's/\/\/ includeConfig/includeConfig/' {} \;
working-directory: create-lint-wf

# Replace zenodo.XXXXXX to pass readme linting
- name: replace zenodo.XXXXXX
shell: bash
run: find nf-core-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;
working-directory: create-lint-wf

# Run nf-core linting
- name: nf-core lint
# Run nf-core pipelines linting
- name: nf-core pipelines lint
shell: bash
run: nf-core --verbose --log-file log.txt --hide-progress lint --dir nf-core-testpipeline --fail-ignored --fail-warned
run: nf-core --verbose --log-file log.txt --hide-progress pipelines lint --dir nf-core-testpipeline --fail-ignored --fail-warned
working-directory: create-lint-wf

- name: nf-core bump-version to release
- name: nf-core pipelines bump-version to release
shell: bash
run: nf-core --log-file log.txt bump-version --dir nf-core-testpipeline/ 1.1
run: nf-core --log-file log.txt pipelines bump-version --dir nf-core-testpipeline/ 1.1
working-directory: create-lint-wf

- name: nf-core lint in release mode
- name: nf-core pipelines lint in release mode
shell: bash
run: nf-core --log-file log.txt --hide-progress lint --dir nf-core-testpipeline --fail-ignored --fail-warned --release
run: nf-core --log-file log.txt --hide-progress pipelines lint --dir nf-core-testpipeline --fail-ignored --fail-warned --release
working-directory: create-lint-wf

- name: Upload log file artifact
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/changelog.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#! /usr/bin/env python3
"""
Taken from https://github.com/MultiQC/MultiQC/blob/main/.github/workflows/changelog.py and updated for nf-core

Expand All @@ -18,7 +19,7 @@
import re
import sys
from pathlib import Path
from typing import List
from typing import List, Tuple

REPO_URL = "https://github.com/nf-core/tools"

Expand All @@ -32,7 +33,7 @@
assert pr_number, pr_number

# Trim the PR number added when GitHub squashes commits, e.g. "Template: Updated (#2026)"
pr_title = pr_title.removesuffix(f" (#{pr_number})")
pr_title = pr_title.removesuffix(f" (#{pr_number})") # type: ignore

changelog_path = workspace_path / "CHANGELOG.md"

Expand All @@ -50,7 +51,7 @@
sys.exit(0)


def _determine_change_type(pr_title) -> tuple[str, str]:
def _determine_change_type(pr_title) -> Tuple[str, str]:
"""
Determine the type of the PR: Template, Download, Linting, Modules, Subworkflows, or General
Returns a tuple of the section name and the module info.
Expand Down Expand Up @@ -85,7 +86,7 @@ def _determine_change_type(pr_title) -> tuple[str, str]:
pr_link = f"([#{pr_number}]({REPO_URL}/pull/{pr_number}))"

# Handle manual changelog entries through comments.
if comment := comment.removeprefix("@nf-core-bot changelog").strip():
if comment := comment.removeprefix("@nf-core-bot changelog").strip(): # type: ignore
print(f"Adding manual changelog entry: {comment}")
pr_title = comment
new_lines = [
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/create-lint-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
strategy:
matrix:
NXF_VER:
- "23.04.0"
- "24.04.2"
- "latest-everything"
steps:
- name: go to subdirectory and change nextflow workdir
Expand Down Expand Up @@ -78,13 +78,18 @@ jobs:
run: find nf-core-testpipeline -type f -exec sed -i '/TODO nf-core:/d' {} \;
working-directory: create-lint-wf

# Uncomment includeConfig statement
- name: uncomment include config
run: find nf-core-testpipeline -type f -exec sed -i 's/\/\/ includeConfig/includeConfig/' {} \;
working-directory: create-lint-wf

# Run the other nf-core commands
- name: nf-core list
run: nf-core --log-file log.txt list
- name: nf-core pipelines list
run: nf-core --log-file log.txt pipelines list
working-directory: create-lint-wf

- name: nf-core schema
run: nf-core --log-file log.txt schema build --dir nf-core-testpipeline/ --no-prompts
- name: nf-core pipelines schema
run: nf-core --log-file log.txt pipelines schema build --dir nf-core-testpipeline/ --no-prompts
working-directory: create-lint-wf

- name: Cleanup work directory
Expand Down
76 changes: 43 additions & 33 deletions .github/workflows/create-test-lint-wf-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,27 +31,43 @@ env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
prepare-matrix:
name: Retrieve all template features
runs-on: ubuntu-latest
outputs:
all_features: ${{ steps.create_matrix.outputs.matrix }}
steps:
- name: 🏗 Set up yq
uses: frenck/action-setup-yq@v1
- name: checkout
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4
- name: Create Matrix
id: create_matrix
run: |
echo "matrix=$(yq 'keys | filter(. != "github") | filter(. != "is_nfcore") | filter(. != "test_config") | tojson(0)' nf_core/pipelines/create/template_features.yml)" >> $GITHUB_OUTPUT

RunTestWorkflow:
runs-on: ${{ matrix.runner }}
needs: prepare-matrix
env:
NXF_ANSI_LOG: false
strategy:
matrix:
TEMPLATE:
- "template_skip_github_badges.yml"
- "template_skip_igenomes.yml"
- "template_skip_ci.yml"
TEMPLATE: ${{ fromJson(needs.prepare-matrix.outputs.all_features) }}
runner:
# use the runner given by the input if it is dispatched manually, run on github if it is a rerun or on self-hosted by default
- ${{ github.event.inputs.runners || github.run_number > 1 && 'ubuntu-latest' || 'self-hosted' }}
profile: ["self_hosted_runner"]
include:
- TEMPLATE: "template_skip_all.yml"
- TEMPLATE: all
runner: ubuntu-latest
profile: "docker"
- TEMPLATE: "template_skip_nf_core_configs.yml"
- TEMPLATE: nf_core_configs
runner: ubuntu-latest
profile: "docker"
exclude:
- TEMPLATE: nf_core_configs
profile: "self_hosted_runner"
fail-fast: false

steps:
Expand Down Expand Up @@ -80,33 +96,22 @@ jobs:
version: latest-everything

# Create template files
- name: Create template skip all (except github)
- name: Create template skip ${{ matrix.TEMPLATE }}
run: |
mkdir create-test-lint-wf
export NXF_WORK=$(pwd)
printf "prefix: my-prefix\nskip: ['ci', 'github_badges', 'igenomes', 'nf_core_configs']" > create-test-lint-wf/template_skip_all.yml

- name: Create template skip github_badges
run: |
printf "prefix: my-prefix\nskip: github_badges" > create-test-lint-wf/template_skip_github_badges.yml

- name: Create template skip igenomes
run: |
printf "prefix: my-prefix\nskip: igenomes" > create-test-lint-wf/template_skip_igenomes.yml

- name: Create template skip ci
run: |
printf "prefix: my-prefix\nskip: ci" > create-test-lint-wf/template_skip_ci.yml

- name: Create template skip nf_core_configs
run: |
printf "prefix: my-prefix\nskip: nf_core_configs" > create-test-lint-wf/template_skip_nf_core_configs.yml
if [ ${{ matrix.TEMPLATE }} == "all" ]
then
printf "org: my-prefix\nskip_features: ${{ needs.prepare-matrix.outputs.all_features }}" > create-test-lint-wf/template_skip_all.yml
else
printf "org: my-prefix\nskip_features: [${{ matrix.TEMPLATE }}]" > create-test-lint-wf/template_skip_${{ matrix.TEMPLATE }}.yml
fi

# Create a pipeline from the template
- name: create a pipeline from the template ${{ matrix.TEMPLATE }}
run: |
cd create-test-lint-wf
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --template-yaml ${{ matrix.TEMPLATE }}
nf-core --log-file log.txt pipelines create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --template-yaml template_skip_${{ matrix.TEMPLATE }}.yml

- name: run the pipeline
run: |
Expand All @@ -119,8 +124,8 @@ jobs:
rm -rf create-test-lint-wf/results

# Try syncing it before we change anything
- name: nf-core sync
run: nf-core --log-file log.txt sync --dir create-test-lint-wf/my-prefix-testpipeline/
- name: nf-core pipelines sync
run: nf-core --log-file log.txt pipelines sync --dir create-test-lint-wf/my-prefix-testpipeline/

# Run code style linting
- name: Run pre-commit
Expand All @@ -132,24 +137,29 @@ jobs:
run: find my-prefix-testpipeline -type f -exec sed -i '/TODO nf-core:/d' {} \;
working-directory: create-test-lint-wf

# Uncomment includeConfig statement
- name: uncomment include config
run: find my-prefix-testpipeline -type f -exec sed -i 's/\/\/ includeConfig/includeConfig/' {} \;
working-directory: create-test-lint-wf

# Replace zenodo.XXXXXX to pass readme linting
- name: replace zenodo.XXXXXX
run: find my-prefix-testpipeline -type f -exec sed -i 's/zenodo.XXXXXX/zenodo.123456/g' {} \;
working-directory: create-test-lint-wf

# Run nf-core linting
- name: nf-core lint
run: nf-core --log-file log.txt --hide-progress lint --dir my-prefix-testpipeline --fail-warned
- name: nf-core pipelines lint
run: nf-core --log-file log.txt --hide-progress pipelines lint --dir my-prefix-testpipeline --fail-warned
working-directory: create-test-lint-wf

# Run bump-version
- name: nf-core bump-version
run: nf-core --log-file log.txt bump-version --dir my-prefix-testpipeline/ 1.1
- name: nf-core pipelines bump-version
run: nf-core --log-file log.txt pipelines bump-version --dir my-prefix-testpipeline/ 1.1
working-directory: create-test-lint-wf

# Run nf-core linting in release mode
- name: nf-core lint in release mode
run: nf-core --log-file log.txt --hide-progress lint --dir my-prefix-testpipeline --fail-warned --release
- name: nf-core pipelines lint in release mode
run: nf-core --log-file log.txt --hide-progress pipelines lint --dir my-prefix-testpipeline --fail-warned --release
working-directory: create-test-lint-wf

- name: Tar files
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/create-test-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
strategy:
matrix:
NXF_VER:
- "23.04.0"
- "24.04.2"
- "latest-everything"
steps:
- name: go to working directory
Expand Down Expand Up @@ -70,8 +70,8 @@ jobs:
run: |
mkdir create-test-wf && cd create-test-wf
export NXF_WORK=$(pwd)
nf-core --log-file log.txt create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface" --plain
nextflow run nf-core-testpipeline -profile test,self_hosted_runner --outdir ./results
nf-core --log-file log.txt pipelines create -n testpipeline -d "This pipeline is for testing" -a "Testing McTestface"
nextflow run nf-core-testpipeline -profile self_hosted_runner,test --outdir ./results

- name: Upload log file artifact
if: ${{ always() }}
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
- name: List tests
id: list_tests
run: |
echo "tests=$(find tests/test_* | tac | sed 's/tests\///g' | jq -R -s -c '{test: (split("\n")[:-1])}')" >> $GITHUB_OUTPUT
echo "tests=$(find tests -type f -name "test_*.py" | tac | sed 's/tests\///g' | jq -R -s -c '{test: (split("\n")[:-1])}')" >> $GITHUB_OUTPUT
outputs:
tests: ${{ steps.list_tests.outputs.tests }}

Expand Down Expand Up @@ -142,10 +142,22 @@ jobs:
exit 1
fi

- name: Store snapshot report
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4
if: always()
with:
name: Snapshot Report ${{ matrix.test }}
path: ./snapshot_report.html

- name: remove slashes from test name
run: |
test=$(echo ${{ matrix.test }} | sed 's/\//__/g')
echo "test=${test}" >> $GITHUB_ENV

- name: Upload coverage
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4
with:
name: coverage_${{ matrix.test }}
name: coverage_${{ env.test }}
path: .coverage

coverage:
Expand Down
Loading
Loading