bump_version: don't require pipeline version in nf-test snapshots
#3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
changed the title
bump_version: don't require pipeline version in nf-test snapshots
|
@nf-core-bot changelog |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mirpedrol
reviewed
Mar 5, 2025
| @@ -101,7 +101,7 @@ def bump_pipeline_version(pipeline_obj: Pipeline, new_version: str) -> None: | |||
| ) | |||
| # nf-test snap files | |||
| pipeline_name = pipeline_obj.nf_config.get("manifest.name", "").strip(" '\"") | |||
| snap_files = [f for f in Path().glob("tests/pipeline/*.snap")] | |||
| snap_files = [f for f in Path(pipeline_obj.wf_path).glob("tests/pipeline/*.snap")] | |||
There was a problem hiding this comment.
I think the workflow path is not needed, we use relative paths for all other paths in update_file_version , so we should modify the file paths resulting from this glob
| @@ -288,7 +289,7 @@ def update_text_file(fn: Path, patterns: List[Tuple[str, str]], required: bool): | |||
| updated = True | |||
| log.info(f"Updated version in '{fn}'") | |||
| log.debug(f"Replaced pattern '{pattern}' with '{replacement}' {count} times") | |||
| elif required: | |||
| else: | |||
There was a problem hiding this comment.
won't this show the error when the version is not found? even if required is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.