Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline linting nf-core component behaviour #3480

Merged
merged 17 commits into from
Mar 6, 2025
Merged

Fix pipeline linting nf-core component behaviour #3480

merged 17 commits into from
Mar 6, 2025
+3 −2

Conversation

LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Mar 5, 2025 •
edited
Loading

PR checklist

This should fix #3478

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@LouisLeNezet LouisLeNezet changed the title Fix pipelin linting nf-core component behaviour Fix pipeline linting nf-core component behaviour Mar 5, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.64%. Comparing base (67146de) to head (3365067).
Report is 18 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LouisLeNezet LouisLeNezet linked an issue Mar 5, 2025 that may be closed by this pull request
Lint modules and sbwf with nf-core pipelines lint by default #3478
Closed
@LouisLeNezet
Copy link
Contributor Author

This should be good now and we can see all the warnings in the linting that we didn't see before.

@LouisLeNezet LouisLeNezet requested a review from mirpedrol March 5, 2025 23:35
mirpedrol
mirpedrol approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@LouisLeNezet LouisLeNezet merged commit 8451416 into nf-core:dev Mar 6, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint modules and sbwf with nf-core pipelines lint by default
2 participants
@LouisLeNezet @mirpedrol