Rework data nodes #356
Merged
Rework data nodes #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…headers with "Data" #93
Freymaurer
requested changes
May 6, 2024
src/Core/Conversion.fs
Outdated
| | CompositeHeader.Output IOType.DerivedDataFile -> ProcessOutput.createDerivedData(value.ToString()) | ||
| | CompositeHeader.Output IOType.Data -> ProcessOutput.createImageFile(value.ToString()) | ||
| | CompositeHeader.Output IOType.Data -> ProcessOutput.createRawData(value.ToString()) | ||
| | CompositeHeader.Output IOType.Data -> ProcessOutput.createDerivedData(value.ToString()) |
Freymaurer
requested changes
May 15, 2024
src/Core/ArcTypes.fs
Outdated
There was a problem hiding this comment.
datamap missing in ToString override
src/Core/Process/Data.fs
Outdated
| @@ -1,31 +1,36 @@ | |||
| namespace ARCtrl.Process | |||
| namespace ARCtrl | |||
There was a problem hiding this comment.
Why is this not ARCtrl.Process anymore? but still located in Process folder? Depending on the answer, the record type should be changed to class
There was a problem hiding this comment.
Because the type is now also used in the ArcTable. But as it is now being referenced both from ArcTable and Process, finding a place in the project is a bit difficult.
| @@ -15,10 +15,12 @@ type CompositeCell = | |||
| /// | |||
| /// https://isa-specs.readthedocs.io/en/latest/isatab.html#unit | |||
| | Unitized of string*OntologyAnnotation | |||
| | Data of Data | |||
There was a problem hiding this comment.
If this Data is the Data from Process/Data.fs then Data must be changed to class with AttachMembers!
tests/Core/ARCtrl.Core.Tests.fsproj
Outdated
| <PackageReference Include="Fable.Pyxpecto" Version="1.0.1" /> | ||
| <PackageReference Include="Fable.Core" Version="4.2.0" /> |
There was a problem hiding this comment.
Fable.Core dependency seems irrelevant as this should come from project reference?
Freymaurer
requested changes
May 28, 2024
Freymaurer
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARC-Specification#93
#300
ARC-Specification#93
ARC-Specification#104