Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tryGetColumnByHeaderBy member and static + tests #441

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

olscholz
Copy link
Contributor

@olscholz olscholz commented Sep 16, 2024

Changes in ArcTable.fs and ArcTable.Tests.fs adding the functionality discussed in Issue #440

Changes in ArcTavle.fs and ArcTable.Tests.fs adding the functionality discussed in Issue nfdi4plants#440
Copy link
Member

@HLWeil HLWeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just small changes to the test names

tests/Core/ArcTable.Tests.fs Outdated Show resolved Hide resolved
tests/Core/ArcTable.Tests.fs Outdated Show resolved Hide resolved
small changes to testCases for tryGetColumnByHeaderBy
@HLWeil HLWeil merged commit 32875d5 into nfdi4plants:main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants