Make OntologyAnnotation work with localID as TAN #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freymaurer
requested changes
Oct 23, 2024
| @@ -42,8 +42,14 @@ type OntologyAnnotation(?name,?tsr,?tan, ?comments) = | |||
|
|
|||
| member this.TANInfo = | |||
| match this.TermAccessionNumber with | |||
| | Some v -> | |||
| Regex.tryParseTermAnnotation v | |||
| | Some tan -> | |||
There was a problem hiding this comment.
this should be kind of reverse right?
We have one example the paff(?) subnamespace in the MS ontology. Using this as example we would have:
TSR: MS; TAN: PEFF:0001032
Then we want to return {| IDSpace = MS; LocalID = PEFF:0001032 |}
In my opinion we should give a explicitly set TSR priority.
There was a problem hiding this comment.
But then we would have MS:PEFF:0001032 as the short-annotation.
There was a problem hiding this comment.
Ahh sorry my bad! Didnt fully understand the function context. All good from my side
Freymaurer
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #437