Skip to content

Commit

Permalink
Add some name cleans (#149)
Browse files Browse the repository at this point in the history
* Added 4 name cleans

Gabriel Davis, Kenneth Walker, Demario Davis, Ahmad Gardner.

* Additions

Jackrabbit -> Janoris Jenkins, Deonte Harris -> Harty, Darius -> Shaquille Leonard, Robby -> Robbie Anderson

* rebuild datafile, bumpver

Co-authored-by: Tan Ho <[email protected]>
Co-authored-by: Tan Ho <[email protected]>
  • Loading branch information
3 people authored Sep 23, 2022
1 parent 3263f16 commit fc57cf3
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: nflreadr
Title: Download 'nflverse' Data
Version: 1.3.0.05
Version: 1.3.0.06
Authors@R: c(
person("Tan", "Ho", , "[email protected]", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0001-8388-5155")),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- `load_participation()` now joins pbp on via `nflverse_game_id` instead of `old_game_id` (v1.3.0.04)
- `clean_player_names()` now fully lives in nflreadr, the squish/trim happens first (v1.3.0.05)
- `progressively()` now works with lambda functions and no longer checks for progressors. (allows cli)
- player name mapping update (v1.3.0.06)

---

Expand Down
1 change: 1 addition & 0 deletions data-raw/build_teamplayer_mappings.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ library(usethis)
player_name_mapping <- read.csv("data-raw/clean_player_names.csv") |>
dplyr::select(alt_name, correct_name) %>%
dplyr::distinct(alt_name, .keep_all = TRUE) %>%
dplyr::mutate_all(stringr::str_squish) |>
tibble::deframe()

usethis::use_data(player_name_mapping, overwrite = TRUE)
Expand Down
8 changes: 8 additions & 0 deletions data-raw/clean_player_names.csv
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,11 @@ Carlos Basham,Boogie Basham
Patrick Surtain,Pat Surtain
Joe Tryon-Shoyinka,Joe Tryon
Cameron Sample,Cam Sample
Gabriel Davis,Gabe Davis
Kenneth Walker,Ken Walker
Demario Davis,DeMario Davis
Ahmad Gardner,Sauce Gardner
Janoris Jenkins,Jackrabbit Jenkins
Deonte Harty,Deonte Harris
Shaquille Leonard,Darius Leonard
Robbie Anderson,Robby Anderson
Binary file modified data/player_name_mapping.rda
Binary file not shown.

0 comments on commit fc57cf3

Please sign in to comment.