revamp sitrep and nflverse_data class #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanho63
reviewed
Aug 10, 2023
tanho63
force-pushed
the
sitrep-improvements
branch
from
16563fe
to
2dbe2b0
Compare
tanho63
reviewed
Aug 10, 2023
tanho63
previously approved these changes
Aug 10, 2023
tanho63
reviewed
Aug 10, 2023
|
|
||
| name: ${{ matrix.config.os }} (${{ matrix.config.r }}) | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: | ||
| - {os: windows-latest, r: 'release', rspm: "https://packagemanager.rstudio.com/all/latest"} | ||
| #- {os: windows-latest, r: '3.6', rspm: "https://packagemanager.rstudio.com/cran/latest"} | ||
| - {os: macOS-latest, r: 'release', rspm: "https://packagemanager.rstudio.com/all/latest"} |
There was a problem hiding this comment.
@mrcaseb maybe it was that we were installing mac pkgs from RSPM instead of whatever the default is?
There was a problem hiding this comment.
yeah that's what I figured and why I decided to test a newer workflow. I hope it resolves our problems and stops annoying us
tanho63
previously approved these changes
Aug 10, 2023
|
may need to bypass merge checks and then update which checks are being keyed on again |
|
changed required checks in branch protection rules. We could merge now but we found some problems with pak |
tanho63
previously approved these changes
Aug 10, 2023
tanho63
force-pushed
the
sitrep-improvements
branch
from
aa60ef0
to
8ca88bf
Compare
tanho63
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #198
I moved the code into a fresh branch because git couldn't identify actual code changes (maybe encoding or line ending)