Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roster status descriptor #232 #243

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Add roster status descriptor #232 #243

merged 3 commits into from
Sep 22, 2024

Conversation

john-b-edwards
Copy link
Contributor

Not going to document status_description_abbr because it's crazy messy and way too niche but this should provide a good guide for roster statuses

@john-b-edwards
Copy link
Contributor Author

Resolves #232

@tanho63
Copy link
Member

tanho63 commented Aug 5, 2024 •
edited
Loading

Can we add dictionary_roster_status:

tanho63
tanho63 reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(clearing out my GH notifications) a couple of changes requested

tanho63
tanho63 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty!

@tanho63 tanho63 merged commit 419cd1c into main Sep 22, 2024
7 checks passed
@tanho63 tanho63 deleted the roster-status-dict branch September 22, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanho63 tanho63 tanho63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-b-edwards @tanho63