Updated player mappings. #249
Conversation
because of stupid attribute checks in new arrow version
|
My commit doesn't fix the problem because it applies only for multiple files. We need to fix the attributes in parquet files in the releases |
This reverts commit 2342d73.
|
Parquet problems in tests are fixed. This PR is up to you now, @tanho63 |
data-raw/clean_player_names.csv
Outdated
| Michael Danna,Mike Danna | ||
| Ogbonnia Okoronkwo,Ogbo Okoronkwo | ||
| Henry To'oTo'o,Henry TooToo |
There was a problem hiding this comment.
I don’t think there is a scenario where clean names will keep these apostrophes, it is hardcoded to remove them. That probably makes the entry redundant.
|
Yes but also a quick question. This was an immediate fix I submitted for an auction that’s now over. Now that I have proof of concept in submitting the PR would it be better to submit just this now or submit a more full one with a complete mapping fix? Or should I do a second one for the complete fix? |
|
submit now and then PR the remainder after if you want |
|
Also, I now have the full list of names I actually want to change. Should I wait for this PR to go through first or just close this one and re-open a new one with the full list? |
Ok I followed all the steps! Let me know if this works. Not sure if this file really needs the blank line at the end still. Not sure how to add that; hopefully it works without a blank line.