Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcaptcha: replace ensurePermissions #159

Merged
merged 3 commits into from
Apr 12, 2024
Merged

mcaptcha: replace ensurePermissions #159

merged 3 commits into from
Apr 12, 2024

Conversation

mightyiam
Copy link
Member

Towards #126

@github-actions GitHub Actions
Copy link
Contributor

No difference in nix flake show.

mightyiam
mightyiam commented Feb 14, 2024
View reviewed changes
Copy link
Member Author

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is tested here:

ngipkgs/tests/mcaptcha-create-locally/default.nix

Line 17 in 9fd2fa3

services.mcaptcha.database.createLocally = true;

mightyiam
mightyiam commented Feb 14, 2024
View reviewed changes
modules/mcaptcha.nix Outdated Show resolved Hide resolved
@lorenzleutgeb lorenzleutgeb marked this pull request as ready for review April 12, 2024 09:46
@github-actions GitHub Actions
Copy link
Contributor

No difference in nix flake show.

@github-actions GitHub Actions
Copy link
Contributor

No difference in nix flake show.

@lorenzleutgeb lorenzleutgeb merged commit 84e9848 into main Apr 12, 2024
2 checks passed
@lorenzleutgeb lorenzleutgeb deleted the ensure-permissions-mcaptcha branch April 12, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzleutgeb lorenzleutgeb lorenzleutgeb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mightyiam @lorenzleutgeb