Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove nix flake show diff generation #176

Merged
merged 1 commit into from
Apr 12, 2024
Merged

ci: Remove nix flake show diff generation #176

merged 1 commit into from
Apr 12, 2024

Conversation

lorenzleutgeb
Copy link
Member

As discussed with @fricklerhandwerk, cost/benefit is too high:

  • Complex custom implementation.
  • Spams PR comments.
  • GitHub's change overview is good enough (will be even better once Metadata #74 is done).
  • Adds complexity to permissions.

@lorenzleutgeb lorenzleutgeb mentioned this pull request Apr 12, 2024
Closed
@fricklerhandwerk fricklerhandwerk merged commit 8992a02 into main Apr 12, 2024
2 checks passed
@fricklerhandwerk fricklerhandwerk deleted the nix-flake-show-pr-comment-diff branch April 12, 2024 10:50
@lorenzleutgeb lorenzleutgeb mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzleutgeb @fricklerhandwerk