-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial zone_sync
values to the ConfigMap
#7239
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7239 +/- ##
==========================================
+ Coverage 52.72% 52.74% +0.02%
==========================================
Files 89 89
Lines 20843 20886 +43
==========================================
+ Hits 10989 11016 +27
- Misses 9396 9407 +11
- Partials 458 463 +5 ☔ View full report in Codecov by Sentry. |
@AlexFenlon Just a heads up, we will need to update our ConfigMap keys in confluence with this new setting. This doesn't have to do in this PR, but just to make sure it's captured |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with questions around naming things.
Proposed changes
This pr adds the following
zone_sync
values to the defaultnginx-config
ConfigMap.zone-sync-port
requireszone-sync
to be enabled, which in turn needs NGINX Plus enabled.Domain is also added and is written dynamically based on the namespace of the controller eg.
nginx-ingress-headless.nginx-ingress.svc.cluster.local
This PR only just adds the values and the validation for it, the user cannot enter anyhing until future implementation.
Resolves: #7218
Checklist
Before creating a PR, run through this checklist and mark each as complete.