Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and resolve CI Fail #98

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Update README and resolve CI Fail #98

merged 4 commits into from
Apr 29, 2024

Conversation

jswongF5
Copy link
Collaborator

@jswongF5 jswongF5 commented Apr 29, 2024

Proposed changes

This PR takes care of the following

  1. There were questions about including a private Ansible collection in the README which is not needed for this role to work. It was mainly used to document an example of using this role to count the number of NIGNX Plus instances.
  2. Resolve CI failure. The NGINX Plus Count CI is failing because Debian 10 is no longer supported. Removing testing this version.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@jswongF5 jswongF5 self-assigned this Apr 29, 2024
@jswongF5 jswongF5 merged commit 9973750 into main Apr 29, 2024
17 checks passed
@jswongF5 jswongF5 deleted the update-count branch April 29, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant