Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-copying the NGINX Amplify config file every time the role is re-run #679

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Dec 15, 2023

Proposed changes

And add Molecule tests for NGINX Amplify. Fixes #667.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document.
  • I have added Molecule tests that prove my fix is effective or that my feature works.
  • I have checked that any relevant Molecule tests pass after adding my changes.
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md).

And add Molecule tests for NGINX Amplify. Fixes #667.
@alessfg alessfg self-assigned this Dec 15, 2023
@alessfg alessfg added bug Something isn't working tests Improvements to tests labels Dec 15, 2023
@alessfg alessfg added this to the 0.24.3 milestone Dec 15, 2023
@alessfg alessfg changed the title Avoid re-copying the NGINX Amplify config file every time the role is run Avoid re-copying the NGINX Amplify config file every time the role is re-run Dec 15, 2023
@alessfg alessfg merged commit 27ddc2c into main Dec 15, 2023
16 checks passed
@alessfg alessfg deleted the test-amplify branch December 15, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improvements to tests
Development

Successfully merging this pull request may close these issues.

NGINX Amplify installation changes agent.conf even if it's already in the desired state
1 participant