fix: conditional statements jinja2 warning #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ansible-core version is updated from 2.15.4 to 2.15.8
the following warning occurs:
[WARNING]: conditional statements should not include jinja2 templating
delimiters such as {{ }} or {% %}
Fixed by removing the delimeters.
Signed-off-by: Ilari Iso-Junno <[email protected]>
alessfg
approved these changes
Jan 12, 2024
alessfg
reviewed
Jan 12, 2024
tasks/validate/validate.yml
Outdated
| if ansible_facts['distribution'] | lower in ['alpine', 'ubuntu'] else ansible_facts['distribution_major_version'] in nginx_distributions[ansible_facts['distribution'] | lower]['versions'] | string }}" | ||
| - "{{ ansible_facts['architecture'] in nginx_distributions[ansible_facts['distribution'] | lower]['architectures'] }}" | ||
| - ansible_facts['distribution'] | lower in nginx_distributions.keys() | list | ||
| - (ansible_facts['distribution_version'] | regex_search('\\d{1,2}\\.\\d{2}') | float in nginx_distributions[ansible_facts['distribution'] | lower]['versions'] | map('float') |
There was a problem hiding this comment.
Can you move the parentheses back to where they were? I've run into situations using the "X if Y" conditional in Ansible has led to issues when the "X" was not wrapped in parentheses.
alessfg
requested changes
Jan 12, 2024
|
Based on my manual testing, the short parenthesis (code before if) did not
add any value and therefore removed them.
The two line block did not work without parenthesis around the whole block.
Therefore added them.
Feel free to add the short parenthesis back. I can do it next Tuesday.
pe 12. tammik. 2024 klo 22.53 Alessandro Fael Garcia <
***@***.***> kirjoitti:
… ***@***.**** requested changes on this pull request.
See the comment I made in the review 😄
—
Reply to this email directly, view it on GitHub
<#685 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIWNXSAZCIRCPKS7IADI6DYOGPFLAVCNFSM6AAAAABBYLHNAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJZGAZDQNBSGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
It's not needed in this case, but it's there for consistency around this role and the config role. That being said, after removing the curly braces and double quotes, something (e.g. parentheses) had to be used to ensure that it works given that it's a multiline conditional. I'll readd them on Monday 😄 |
alessfg
approved these changes
Jan 15, 2024
|
I ended up flattening everything into a single line 👌 |
alessfg
pushed a commit
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ansible-core version is updated from 2.15.4 to 2.15.8 the following warning occurs:
[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}
Fixed by removing the delimeters.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument.defaults/main/*.yml,README.mdandCHANGELOG.md).