Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mariadbd binary #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

handymenny
Copy link

Starting with MariaDB 10.5.2 the binary is named mariadbd
Reference: https://jira.mariadb.org/browse/MDEV-21303

Starting with MariaDB 10.5.2 the binary is named mariadbd
Reference: https://jira.mariadb.org/browse/MDEV-21303
@Berserker66
Copy link

This appears to address #83 and I'd like to see mariadb support.

@miken32
Copy link

miken32 commented Jan 15, 2025

@defanator is something wrong with this pull request that it never got accepted? Seems like a very innocuous change, that would make a big improvement for users.

Only problem I see with it is the conditional should be if cmd.split(' ', 1)[0].endswith('mysqld') or cmd.split(' ', 1)[0].endswith('mariadbd'): instead of making it only check for trailing d. Works fine for me in local testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants