Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile fix #298

Merged
merged 2 commits into from
May 9, 2024
Merged

makefile fix #298

merged 2 commits into from
May 9, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented May 9, 2024

Proposed changes

correct makefile version

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner May 9, 2024 09:58
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label May 9, 2024
@pdabelf5 pdabelf5 merged commit 20bd60d into main May 9, 2024
5 checks passed
@pdabelf5 pdabelf5 deleted the version-fix branch May 9, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @oseoin @j1m-ryan