fix(entities): correct behavior of upsertEntities with duplicate ids (

#519)
ngneat · Apr 16, 2024 · 9411e87 · 9411e87
1 parent 9dbc51d
commit 9411e87
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/entities/src/lib/update.mutation.spec.ts b/packages/entities/src/lib/update.mutation.spec.ts
@@ -259,6 +259,19 @@ describe('update', () => {
 
       expect(ids).toBe(sameIds);
     });
+
+    it('should be able to handle duplicate ids', () => {
+      const store = createEntitiesStore();
+      store.update(
+        upsertEntities([
+          { id: 1, completed: true },
+          { id: 1, completed: false },
+        ]),
+      );
+      const { ids, entities } = store.getValue();
+      expect(ids).toEqual([1]);
+      expect(entities).toEqual({ 1: { id: 1, completed: false } });
+    });
   });
 
   describe('UpdateEntitiesIds', () => {

diff --git a/packages/entities/src/lib/update.mutation.ts b/packages/entities/src/lib/update.mutation.ts
@@ -228,8 +228,9 @@ export function upsertEntities<
 
     for (const entity of entitiesArray) {
       const id: getIdType<S, Ref> = entity[idKey];
-      // if entity exists, merge update, else add
-      if (hasEntity(id, options)(state)) {
+      if (asObject[id]) {
+        asObject[id] = { ...asObject[id], ...entity };
+      } else if (hasEntity(id, options)(state)) {
         asObject[id] = { ...state[entitiesKey][id], ...entity };
         updatedEntitiesId.push(id);
       } else {