-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to signal inputs #157
base: master
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@arturovt Isn't (one of) the purpose of signals to avoid using the |
I haven’t heard of avoiding ngOnChanges. If an effect running on a signal change may internally update some other signals, this will lead to a runtime error, or capture other signals being read. |
Please, read Netanel's article about signal inputs: https://netbasal.com/revolutionizing-angular-introducing-the-new-signal-input-api-d0fc3c8777f2
Therefore, many of those |
@frezo00 eliminates !== avoid |
Sure, my mistake in the first comment, should have used another verb 😅 |
No description provided.