-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change hasura health check url to make auth server work in gcp #565
Conversation
Hi, thanks for the PR.
Where does it say that? I couldn't find any reference to it. Do you have any documentation we can reference? Regarding the change, unfortunately, it isn't good (and doesn't work) for two main reasons:
To properly perform this change you will have to:
Also, don't call the endpoint |
Workloads in Google Cloud cannot have URL paths with here is the proof (hasrua hosted in google Cloud Run) When I think there is some misunderstanding here: Important Hasura include both health-check endpoints in all deployment environments. we don't have to do anything for hasura. I think this change will not have any side-effect |
yes, you are completely right. I totally misinterpreted the change. Thanks for the clarification. However, if you need this change because you are hosting hasura in GCP, wouldn't you also need an alternative /health endpoint for hasura-auth? |
since hasura auth health check end point is not called through the loadbalancer by any client we dint need it. |
Would be nice to have alternative health-check endpoints for all nhost services that won't conflict with GCP. |
Google cloud doesnt support "z" urls - https://stackoverflow.com/questions/43380939/where-does-the-convention-of-using-healthz-for-application-health-checks-come-f
And hasura provides an alternate end point for this https://hasura.io/docs/2.0/api-reference/health/ .
Checklist