MAV-745: Give artifacts unique names (#3109)

- Artifacts with same name cannot exist in one workflow - Therefore the continuous_deployment workflow failed
nhsuk · Feb 28, 2025 · 3e75661 · 3e75661
2 parents 548996b + efaecb6
commit 3e75661
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/continuous_deployment.yml b/.github/workflows/continuous_deployment.yml
@@ -16,6 +16,6 @@ jobs:
       environment: "copilotmigration"
   DeployApplication:
     needs: [Build, DeployInfrastructure]
-    uses: ./.github/workflows/deploy_mavis.yml
+    uses: ./.github/workflows/deploy_application.yml
     with:
       environment: "copilotmigration"
diff --git a/.github/workflows/deploy_mavis.yml → .github/workflows/deploy_application.yml b/.github/workflows/deploy_mavis.yml → .github/workflows/deploy_application.yml
@@ -1,5 +1,5 @@
-name: TF Deploy Mavis
-run-name: TF Deploy Mavis on ${{ inputs.environment }}
+name: TF Deploy Application
+run-name: TF Deploy Application on ${{ inputs.environment }}
 
 on:
   workflow_dispatch:
@@ -76,7 +76,7 @@ jobs:
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
-          name: tfplan
+          name: tfplan_app
           path: ${{ runner.temp }}/tfplan
   DeployUpdate:
     runs-on: ubuntu-latest
@@ -95,8 +95,8 @@ jobs:
       - name: Download artifact
         uses: actions/download-artifact@v4
         with:
-          name: tfplan
-          path: ${{ runner.temp }}/artifact
+          name: tfplan_app
+          path: ${{ runner.temp }}
       - name: Install terraform
         uses: hashicorp/setup-terraform@v3
         with:
@@ -105,7 +105,7 @@ jobs:
         working-directory: ${{ env.tf-dir }}
         run: |
           terraform init -backend-config="env/${{ inputs.environment }}-backend.hcl"
-          terraform apply ${{ runner.temp }}/artifact/tfplan
+          terraform apply ${{ runner.temp }}/tfplan_app
           echo "s3_bucket=$(terraform output -raw s3_bucket)" >> ${{ runner.temp }}/CODEDEPLOY_ENV
           echo "s3_key=$(terraform output -raw s3_key)" >> ${{ runner.temp }}/CODEDEPLOY_ENV
           echo "application=$(terraform output -raw codedeploy_application_name)" >> ${{ runner.temp }}/CODEDEPLOY_ENV

diff --git a/.github/workflows/deploy_infrastructure.yml b/.github/workflows/deploy_infrastructure.yml
@@ -88,7 +88,7 @@ jobs:
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
-          name: tfplan
+          name: tfplan_infrastructure
           path: ${{ runner.temp }}/tfplan
   ApplyUpdate:
     runs-on: ubuntu-latest
@@ -107,7 +107,7 @@ jobs:
       - name: Download artifact
         uses: actions/download-artifact@v4
         with:
-          name: tfplan
+          name: tfplan_infrastructure
           path: ${{ runner.temp }}
       - name: Install terraform
         uses: hashicorp/setup-terraform@v3
@@ -117,4 +117,4 @@ jobs:
         working-directory: ${{ env.tf_dir }}
         run: |
           terraform init -backend-config="env/${{ inputs.environment }}-backend.hcl"
-          terraform apply ${{ runner.temp }}/tfplan
+          terraform apply ${{ runner.temp }}/tfplan_infrastructure