Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format full names as SURNAME, Firstname #2980

Open
wants to merge 2 commits into
base: v2.1.0-wip
Choose a base branch
from
Open

Format full names as SURNAME, Firstname #2980

wants to merge 2 commits into from

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Feb 17, 2025 •
edited
Loading

This updates how the full names are formatted to use the format SURNAME, Firstname if we're rendering a patient name in the context of the service used by nurses, and we keep the existing Firstname Surname format when displaying a patient name in the context of comms sent to parents.

Screenshots

Screenshot 2025-02-26 at 08 21 54
Screenshot 2025-02-26 at 08 22 00
Screenshot 2025-02-26 at 08 22 10
Screenshot 2025-02-26 at 08 23 35

@thomasleese thomasleese added the ✨ feature New functionality label Feb 17, 2025
@thomasleese thomasleese changed the title Improve full name formatting Format full names as "SURNAME, Firstname" Feb 26, 2025
@thomasleese thomasleese changed the title Format full names as "SURNAME, Firstname" Format full names as SURNAME, Firstname Feb 26, 2025
@thomasleese thomasleese marked this pull request as ready for review February 26, 2025 09:24
@thomasleese thomasleese added this to the v2.1.0 milestone Feb 28, 2025
@thomasleese thomasleese changed the base branch from main to v2.1.0-wip March 3, 2025 12:35
@thomasleese
Add FullNameFormatter
8712b8c 
This adds a class which formats a full name (made up of a given name and
a family name) in given format context, either internal use or
communication with parents.

The internal use format will use "FAMILY, Given" as the format and for
parents it will remain as "Given Family".
@thomasleese
Use FullNameFormatter
290b664 
This updates the various places in the service where a name is rendered
to use the new `FullNameFormatter` class to ensure that it's formatted
correctly.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benilovj benilovj benilovj approved these changes

@tvararu tvararu tvararu approved these changes

Assignees
No one assigned
Labels
✨ feature New functionality
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasleese @benilovj @tvararu