Pre commit implementation #3001
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneFromNorway
force-pushed
the
pre-commit_implementation
branch
3 times, most recently
from
382e652 to
eeff2bc
Compare
- Run pre-commit as part of the linting workflow - Run some checks just in the pipeline - Use manual hooks for this purpose - Try to reproduce linting behviour - Run both in pipeline to test outcome
* Format files to be compliant with pre-commit
- Revert some erronious formation for .erb files
- Modify hooks to run as expected
- e.g.not passing file names
- brakeman hangs on pager if not excluded in hook
- Remove shellcheck it was too noisy at this stage
- Remove yaml check
- A lot of copilot/configuraiton files do not conform to the check
apparently
* Ensure tflint is happy
* Fix linting workflow to do necessary setups * Ensure we run rubocop the right way
TheOneFromNorway
force-pushed
the
pre-commit_implementation
branch
from
af63eee to
ec77b5c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.