Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove small blue badge variant #235

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove small blue badge variant #235

merged 2 commits into from
Jan 28, 2025

Conversation

davidhunter08
Copy link
Collaborator

@davidhunter08 davidhunter08 commented Jan 24, 2025 •
edited
Loading

Fixes #229

  • changed small badge red to default in CSS
  • removed if red logic from badge macro
  • updated guidance and examples
  • improved spacing between image examples
  • added CHANGELOG entry
Before After
image image

@davidhunter08 davidhunter08 added documentation Improvements or additions to documentation component Add or improve a design component labels Jan 24, 2025
Graham-Pembrey
Graham-Pembrey reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Graham-Pembrey Graham-Pembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "How to use" section, should we also remove the following line?

There are different size and colour variations of badges.

We could leave the size part in, but I think the "Large badge" and "Small badge" headings make that clear anyway.

@davidhunter08
Copy link
Collaborator Author

In the "How to use" section, should we also remove the following line?

There are different size and colour variations of badges.

We could leave the size part in, but I think the "Large badge" and "Small badge" headings make that clear anyway.

Updated @Graham-Pembrey 👍

@davidhunter08 davidhunter08 merged commit fbb003f into main Jan 28, 2025
4 checks passed
@davidhunter08 davidhunter08 deleted the update-badge-guidance branch January 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardscull edwardscull edwardscull approved these changes

@Graham-Pembrey Graham-Pembrey Graham-Pembrey approved these changes

Assignees
No one assigned
Labels
component Add or improve a design component documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update badge colour guidance
3 participants
@davidhunter08 @Graham-Pembrey @edwardscull