WIP Initial implementation of the dl table view #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch is an implementation of the markup-swapping fix for #1092 . It introduces a few new elements: since the
tableuses acaptionand we need to preserve that, butcaptionisn't valid outside atable, thedlimplementation usesfigureandfigcaptionto do the same job.In its current state it is a relatively close match for the previous look and feel across the breakpoints but I haven't done a pixel-scale comparison yet. There's also a failing test, thus the
WIPtitle. I'll fix that shortly, but this is pushed now in case anyone wants to tell me this is completely wrong in some respect.Checklist