Update to only export LIBRARY_EXPORT symbols from the shared library for Linux #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanjiang Qian <[email protected]>
yaqian256
changed the title
ni-sujain
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the Linux build to only export LIBRARY_EXPORT symbols from the shared library.
Currently the labview grpc shared library for Linux exports all symbols. This causes symbol collisions for some use case. For example, the liblabview_grpc_server.so exports the following unique symbols (you can see the full list by running the
nm -C -D liblabview_grpc_server.socommand)If in a labview app that uses grpc-labview, it calls another C library that also uses grpc which also exports the above symbols, there will be collisions.
To avoid that issues, we should update the Linux build (include both Desktop and RT) to only export
LIBRARY_EXPORTsymbols from the shared library. We already do this for the Windows build.