Disable no-await-in-loop for Playwright #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
commented
Sep 7, 2023
change/@ni-eslint-config-playwright-1125d689-3a37-4a84-b8ef-19749c7339f6.json
Show resolved
Hide resolved
TrevorKarjanis
approved these changes
Sep 7, 2023
mure
approved these changes
Sep 11, 2023
rajsite
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
#123 (won't mark it fixed until we uptake this in clients and remove suppressions)
Implementation
Add a rule configuration and docs to the
index.jsfor the Playwright ruleset.Testing
Built package locally, imported into an SLE codebase, and verified that violations no longer need to be suppressed.