Add appearanceVariant to the list of i18n attributes to ignore. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
approved these changes
May 17, 2024
rajsite
added a commit
that referenced
this pull request
May 17, 2024
Minor follow-up to #141 to move `appearanceVariant` to the correct list. The `sl-split-button` uses a different API from nimble currently so has a different name for the localize ignore list. `@Input('appearance-variant') public set appearanceVariant` in nimble vs `@Input() public appearanceVariant` for sl-split-button. Note the difference in the `@Input` decorator configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason,
appearance-variantwas not working, soappearanceVariant, the Angular directive, is required.Notes
appearanceVariantto the list of i18n attributes to ignore.Testing
appearanceVariantis ignored