Remove all grpc_xfail for AB#2393811 and requiring newer gRPC Device …

[texasaggie97]

…Server

• This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Clean up tests to remove grpc_xfail marks that are now expected to pass.

Why should this Pull Request be merged?

More accurately show expectations regarding which tests should pass.

What testing has been done?

PR

[github-actions]

Test Results

    34 files  ±  0      34 suites  ±0   50m 15s ⏱️ + 1m 14s
 2 344 tests ±  0   1 992 ✅ ±  0    352 💤 ±  0  0 ❌ ±0 
42 204 runs  +854  35 986 ✅ +724  6 218 💤 +130  0 ❌ ±0 

Results for commit 03af46b. ± Comparison against base commit 3a990c6.

♻️ This comment has been updated with latest results.

[bkeryan]

What's left?

PS C:\dev\nidaqmx-python> rg -C 1 xfail tests
tests\conftest.py
75-                library_marks.append(pytest.mark.skip(*library_skip.args, **library_skip.kwargs))
76:            library_xfail = metafunc.definition.get_closest_marker("library_xfail")
77:            if library_xfail:
78:                library_marks.append(pytest.mark.xfail(*library_xfail.args, **library_xfail.kwargs))
79-            params.append(pytest.param("library_init_kwargs", marks=library_marks))
--
85-                grpc_marks.append(pytest.mark.skip(*grpc_skip.args, **grpc_skip.kwargs))
86:            grpc_xfail = metafunc.definition.get_closest_marker("grpc_xfail")
87:            if grpc_xfail:
88:                grpc_marks.append(pytest.mark.xfail(*grpc_xfail.args, **grpc_xfail.kwargs))
89-            params.append(pytest.param("grpc_init_kwargs", marks=grpc_marks))

tests\component\test_task_read_ai.py
132-
133:@pytest.mark.xfail(
134-    reason="Task.read interprets data incorrectly for short reads - https://github.com/ni/nidaqmx-python/issues/528",
--
209-
210:@pytest.mark.xfail(
211-    reason="Task.read has inconsistent return type between normal AI and power channels - https://github.com/ni/nidaqmx-python/issues/527",
--
277-
278:@pytest.mark.xfail(
279-    reason="Task.read has inconsistent return type between normal AI and power channels - https://github.com/ni/nidaqmx-python/issues/527",
--
326-
327:@pytest.mark.xfail(
328-    reason="Task.read does not return short reads for multi-channel power - https://github.com/ni/nidaqmx-python/issues/529",

tests\component\test_task_events.py
59-
60:@pytest.mark.grpc_xfail(
61-    reason="#559: Can't close tasks in an event callback when using gRPC", raises=AssertionError
--
112-
113:@pytest.mark.grpc_xfail(
114-    reason="#559: Can't close tasks in an event callback when using gRPC", raises=AssertionError

tests\component\task\test_out_stream_write_properties.py
86-
87:@pytest.mark.grpc_xfail(
88-    reason="AB#2393824: DAQmx read/write status properties return errors when called from C, Python, or grpc-device."

#527 #528 #529 #559 are still open.

AB#2393824 was closed by #537. @texasaggie97 did this one xpass?

[bkeryan]

If tests\component\task\test_out_stream_write_properties.py is xpassing now, then remove its xfail marker too.

[bkeryan]

AB#2393824 was closed by #537. @texasaggie97 did this one xpass?

Correction: this was only fixed for LibraryInterpreter. That's why it's a grpc_xfail. And I was wrong about which bug was closed.