Convert bash script to Python #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texasaggie97
force-pushed
the
users/texasaggie97/convert-script-to-python
branch
2 times, most recently
from
1de463c to
97f27c6
Compare
amstewart
requested changes
Sep 3, 2024
texasaggie97
force-pushed
the
users/texasaggie97/convert-script-to-python
branch
from
97f27c6 to
a0101f9
Compare
texasaggie97
force-pushed
the
users/texasaggie97/convert-script-to-python
branch
5 times, most recently
from
bbbf080 to
9a7ab4a
Compare
Patch V2
|
dmondrik
reviewed
Sep 6, 2024
dmondrik
reviewed
Sep 6, 2024
dmondrik
reviewed
Sep 6, 2024
amstewart
requested changes
Sep 6, 2024
|
@texasaggie97 I just pulled #3. So you may need to rebase this PR on the latest |
amstewart
requested changes
Sep 6, 2024
amstewart
requested changes
Sep 6, 2024
texasaggie97
force-pushed
the
users/texasaggie97/convert-script-to-python
branch
3 times, most recently
from
e5616e7 to
5488d5a
Compare
Patch v3
|
|
@texasaggie97 Are you going to update the _Config class names? |
6 tasks
* Uses python3 and included packages only * Designed to be easy to add additional configurations * Configure complete * Verify complete * Similar functionality to the bash script Signed-off-by: Mark Silva <[email protected]>
texasaggie97
force-pushed
the
users/texasaggie97/convert-script-to-python
branch
from
dd8b58c to
29ad882
Compare
amstewart
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
--dry-runparameter - will not make any changes to the system (both installing/removing packages and updating config files)Justification
Testing
Manual run with nilrt
Procedure
This PR: changes user-visible behavior, fixes a bug, or impacts the project's security profile; and so it includes a CHANGELOG note.