Pin niroco to port 55184 and open it to incoming VPN traffic #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amstewart
requested changes
Dec 16, 2024
amstewart
approved these changes
Dec 16, 2024
amstewart
requested changes
Dec 16, 2024
There was a problem hiding this comment.
See PR error about leftover uninstall files.
https://github.com/ni/nilrt-snac/actions/runs/12362346739/job/34501465747?pr=52#step:5:97
rtollert
force-pushed
the
dev/rtollert/firewall-roco
branch
from
c5cbdb3 to
de5ba1b
Compare
By default, niroco allocates an ephemeral server port, which cannot be effectively firewalled. We can force it to use a specific port with an INI fragment installed to /usr/share/niroco.d, so that _firewall_config.py can allow incoming traffic to that port. We choose port 55184 more or less entirely arbitrarily, but placing it firmly in the ephemeral range more or less demands that this cannot be the long-term static port decision. Signed-off-by: Richard Tollerton <[email protected]>
rtollert
force-pushed
the
dev/rtollert/firewall-roco
branch
from
de5ba1b to
cd405a6
Compare
amstewart
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, niroco allocates an ephemeral server port, which cannot be effectively firewalled. We can force it to use a specific port with an INI fragment installed to /usr/share/niroco.d, so that _firewall_config.py can allow incoming traffic to that port.
We choose port 55184 more or less entirely arbitrarily, but placing it firmly in the ephemeral range more or less demands that this cannot be the long-term static port decision.
Testing
nilrt-snac configuresucceeds and makes the require changes to the firewalld config. New config file added under /usr/share/niroco.d.Procedure