Skip to content

Commit

Permalink
(build): Bump Python version to 3.9 and shift test matrix (#72)
Browse files Browse the repository at this point in the history
Co-authored-by: Carson Moore <[email protected]>
cameronwaterman and mure authored Oct 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 967238b commit 427e978
Showing 9 changed files with 289 additions and 268 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
@@ -11,12 +11,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.9', '3.10', '3.11', '3.12']
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install poetry
run: pipx install poetry
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: "poetry"
@@ -41,7 +41,7 @@ jobs:
run: pipx install poetry
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9
cache: "poetry"
- run: poetry install
- name: Semantic release
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ version: 2
build:
os: ubuntu-20.04
tools:
python: "3.8"
python: "3.9"

# Build documentation in the docs/ directory with Sphinx
sphinx:
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ To contribute to this project, it is recommended that you follow these steps:

## Testing

Before running any tests, you must have a supported version of Python (3.8+) and [Poetry](https://python-poetry.org/docs/) installed locally.
Before running any tests, you must have a supported version of Python (3.9+) and [Poetry](https://python-poetry.org/docs/) installed locally.

It is also helpful to install SystemLink Server and configure the NI Web Server
to run on localhost.
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ Requirements

* A SystemLink Server installation or a
`SystemLink Cloud <https://www.systemlinkcloud.com/>`_ account to connect to
* CPython 3.8+
* CPython 3.9+

.. _installation_section:

4 changes: 1 addition & 3 deletions mypy.ini
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@ mypy_path=nisystemlink/stubs
files=nisystemlink,tests
warn_unused_configs=True
plugins = pydantic.mypy
ignore_missing_imports=True

[mypy-nisystemlink.*]
disallow_untyped_calls=True
@@ -17,6 +18,3 @@ disallow_untyped_calls=True
disallow_untyped_decorators=True

strict_equality=True

[mypy-uplink.*]
ignore_missing_imports=True
3 changes: 3 additions & 0 deletions nisystemlink/clients/testmonitor/_test_monitor_client.py
Original file line number Diff line number Diff line change
@@ -10,6 +10,9 @@


class TestMonitorClient(BaseClient):
# prevent pytest from thinking this is a test class
__test__ = False

def __init__(self, configuration: Optional[core.HttpConfiguration]):
if configuration is None:
configuration = core.JupyterHttpConfiguration()
529 changes: 274 additions & 255 deletions poetry.lock

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -20,16 +20,17 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Operating System :: Microsoft :: Windows",
"Operating System :: POSIX",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: Implementation :: CPython",
"Topic :: Scientific/Engineering",
"Topic :: System :: Hardware",
]

[tool.poetry.dependencies]
python = "^3.8"
python = "^3.9"
aenum = "^3.1.11"
Events = "^0.4"
httpx = "^0.23.0"
2 changes: 1 addition & 1 deletion tests/integration/file/test_file_client.py
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ def invalid_file_id(client: FileClient) -> str:
attempts = 0

while attempts < MAX_RETRIES:
file_id = f"Invalid-File-Id-{randint(1000,9999)}"
file_id = f"Invalid-File-Id-{randint(1000, 9999)}"
files = client.get_files(ids=[file_id])
if files.total_count == 0:
return file_id

0 comments on commit 427e978

Please sign in to comment.